Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This issue will contain the patch that integrates the Edit module into the Toolbar.
#1137920: Fix toolbar on small screen sizes and redesign toolbar for desktop
Development work is happening in the branch node/1825474-toolbar-integration.
Comment | File | Size | Author |
---|---|---|---|
#28 | before.png | 41.7 KB | Wim Leers |
#28 | after.png | 38.88 KB | Wim Leers |
#25 | 1825474_toolbar-integration-25.patch | 7.59 KB | Wim Leers |
#24 | 1825474_toolbar-integration_23-core.patch | 7.5 KB | Wim Leers |
#23 | 1825474_toolbar-integration_23.patch | 7.23 KB | Wim Leers |
Comments
Comment #1
jessebeach CreditAttribution: jessebeach commentedFirst pass at integration.
This will be included in the Spark distribution 8.x alpha build.
Comment #2
jessebeach CreditAttribution: jessebeach commentedThat patch in #1 doesn't apply to the 8.x-1.0-alpha1 tag. Rerolling.
Comment #3
jessebeach CreditAttribution: jessebeach commentedI neglected to move an if statement that prevents the Edit tab from loading on pages that are not editable.
Comment #4
Wim LeersThe first change of http://drupalcode.org/project/edit.git/commitdiff/e8324b5 may but should not conflict with the patch in #3.
I LOVE how we're no longer relying on hook_page_alter() :)
Why also include the icons as data URIs though?
Comment #5
webchickThis no longer applied to me against the latest Edit module code. Here's an attempt at a re-roll.
Comment #6
jessebeach CreditAttribution: jessebeach commentedAttempting a hand-edited patch. Here goes. The icon CSS is now incorrect because of changes to the Toolbar CSS.
Comment #7
webchickOk, one more time.
Wim recommended we stick with the alpha1 release in Spark for now, as Edit module's still in flux. This means going back to the patch in #3 with the icon fix from #6. Attempting to do that here in #7.
Comment #8
webchickLucky try #2? (or #8 in this case?)
Comment #9
jessebeach CreditAttribution: jessebeach commentedUpdated patch has been posted to #1137920: Fix toolbar on small screen sizes and redesign toolbar for desktop. This issue is no longer needed.
Comment #10
jessebeach CreditAttribution: jessebeach commentedDoh, I keep confusing this with the #1825384: Placeholder issue for a patch to enable edit module integration work. Reopening.
Comment #11
jessebeach CreditAttribution: jessebeach commentedUpdated patch.
Comment #12
Wim LeersEdit sets
global $editbar = TRUE
(seeedit_preprocess_field()
) to ensure the view/edit mode toggle ONLY shows up if there's actually something on the page that's editable.I know, it's crappy and evil, but it's also KISS for now.
If you can take that one thing into account, then this looks GREAT :)
Comment #13
webchickThis patch needs a refresh for the new toolbar (now hook_toolbar() instead of hook_toolbar_something_something()) and new Edit module patch available at #1824500-9: In-place editing for Fields.
Comment #14
webchickHere's #11 with hook_toolbar() renamed. Testing.
Comment #15
webchickHere's #11 with hook_toolbar() renamed. Testing.
Comment #16
webchickOk, new patch. Includes fix for CSS and maybe some other things.
Comment #17
jessebeach CreditAttribution: jessebeach commentedIncludes integration with the latest D8 toolbar patch as of #1137920-290: Fix toolbar on small screen sizes and redesign toolbar for desktop.
Comment #18
webchickwellll, shitballs. :( I didn't realize the latest Edit module code wasn't in git, and is instead only in the patch at http://drupal.org/node/1824500#comment-6741906, and when switching to the patch at http://drupal.org/files/in_place_editing_for_fields-9.patch this patch of course no longer applies. I tried applying it manually and now we're back to that lovely thing where it's linking to URL/%23 and getting a 404 and therefore not invoking view/edit mode. UIY@*#&(@#&@# anyway, let's discuss when you're up. ;)
Comment #19
webchickComment #20
Wim Leers#18: that's because I didn't merge the node/1824100-createjs-d8 branch back into the 8.x-1.x branch yet (I was exhausted when I rolled that patch on Friday). No worries though, the server-side part has not changed in any meaningful way, so it'll be easy enough to port over your patch :)
Comment #21
Wim LeersFYI, the node/1824100-createjs-d8 branch has been merged back into the 8.x-1.x branch; I'm currently testing Spark + this patch.
Comment #22
Wim LeersRerolled; now it is working. (The difference: I'm setting the URL fragments; that's how it works now :))
Comment #23
Wim LeersNow *with* icons.
Comment #24
Wim LeersHere's a "Drupal core patch" version of the patch in #23, for use in the Spark distro.
Comment #25
Wim LeersReintroduce the #post_render callback, as mentioned in #22.1 after discussing with @webchick and @Jesse Beach.
Comment #26
Wim LeersNote for #25: the #post_render callback is only called for the tray, not for the tab. In other words: the Edit tab is always present, even if zero editable fields exist on the page.
Comment #27
Wim Leershttp://drupalcode.org/project/edit.git/commit/4ec7f91
Comment #28
Wim LeersBefore:
After:
Comment #29
jessebeach CreditAttribution: jessebeach commentedconditionally rendering the Edit module tab is blocked on: #1847198: Update the structure returned by hook_toolbar()
Comment #30.0
(not verified) CreditAttribution: commentedAdded the dev branch info.