Hi
I have been have the 7.x-2.3 version for a while & this seems to work without incident.
I however wanted to change some settings & when I tried to go to the configuration page (/admin/config/content/mollom), it is BLANK. I have not had any blank errors for many months & in fact have memory set at 200MB, which I think is more than sufficient for this VERY low traffic site.

On the reports & some other pages, I have AT TIMES got this error message: Warning: array_merge(): Argument #2 is not an array in mollom_form_info() (line 919 of /home8/woof/public_html/abc/default/modules/mollom/mollom.module). I have not been having such messages before.

I tried to upgrade to the latest dev version, but this has not helped.
All my modules are up-to-date. To help fight spam, I also have captcha & honey pot, which have helped considerably reduce spam submissions.

Mollom is available on a couple of forms, though.

How do I get of these ugly errors? It surely must be possible to access the configuration page ...

Thank you in advance

CommentFileSizeAuthor
#4 0001-1833262-by-sun-Fixed-mollom_form_info-does-not-log-s.patch1.26 KBsun
#1 mollom.form-info-error.1.patch986 bytessun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Version: 7.x-2.3 » 7.x-2.x-dev
Component: User interface » Code
Status: Active » Needs review
FileSize
mollom.form-info-error.1.patch986 bytes

Can you try attached patch?

lionheart8’s picture

lionheart8 CreditAttribution: lionheart8 commented

Hi

Thank you for the response.

I tried to do the patching but got stuck, although this is not the first time to use a patch.

I got a bit mixed up by this bit:

diff --git a/mollom.module b/mollom.module
index 715d7b9..4a31aa2 100644
--- a/mollom.module
+++ b/mollom.module
@@ -916,7 +916,17 @@ function mollom_form_info($form_id, $module, $form_list = NULL) {
   }

Exactly what did I have to do with the current mollom module script I had (7.x-2.3)?

I otherwise understood the last bit, below "// Any information in hook_mollom_form_info() overrides the list info."

Where I replaced that piece of code
- $form_info = array_merge($form_info, module_invoke($module, 'mollom_form_info', $form_id));
with the lines beginning with "+".

I also tried "7.x-2.3+2-dev of 2012-Nov-14", (which I now have) but still have the blank page at /admin/config/content/mollom

Thank you & kind regards

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs review » Postponed (maintainer needs more info)

Sorry for the delay. I've committed the patch in #1, so there should be a new development snapshot in ~24 hours (tomorrow).

Could you try once again after updating to that tomorrow?

Note that the committed patch will only fix the blank page; it does not fix the underlying problem, which seems to be that a form that was previously protected does no longer exist in your system. It should, however, allow you to remove the bogus/stale form protection.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Postponed (maintainer needs more info) » Needs review
FileSize
0001-1833262-by-sun-Fixed-mollom_form_info-does-not-log-s.patch1.26 KB
sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Version: 6.x-2.x-dev » 7.x-2.x-dev
Status: Needs review » Postponed (maintainer needs more info)

Oh. Apparently, we did not backport #1352012: Feedback options appear for every entity bundle, even when not protected, so this patch makes no sense for D6 right now.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)

I've reverted the commit from #1.

This generally sounds like a duplicate of #804466: Orphan forms of other modules cause errors on administration page

  • Commit 732ef0d on 7.x-2.x, 8.x-2.x, fbajs, actions by sun: 
    - #1833262 by sun: Fixed mollom_form_info() does not log/show an error...
  • Commit 9a8ecb4 on 7.x-2.x, 8.x-2.x, fbajs, actions by sun:
    Revert "- #1833262 by sun: Fixed mollom_form_info() does not log/show an...

  • Commit 732ef0d on 7.x-2.x, 8.x-2.x, fbajs, actions by sun: 
    - #1833262 by sun: Fixed mollom_form_info() does not log/show an error...
  • Commit 9a8ecb4 on 7.x-2.x, 8.x-2.x, fbajs, actions by sun:
    Revert "- #1833262 by sun: Fixed mollom_form_info() does not log/show an...

  • sun committed 732ef0d on 7.x-2.x 
    - #1833262 by sun: Fixed mollom_form_info() does not log/show an error...
  • sun committed 9a8ecb4 on 7.x-2.x
    Revert "- #1833262 by sun: Fixed mollom_form_info() does not log/show an...