Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Move the summary jQuery plugin to it's own file and clean it up. Currently there is too much binding/unbinding going on.
Take formUpdated out of there and to it's own file while making it better: #1636992: form.js' formUpdated event is unreliable/incomplete
Put fillUserInfoFromCookie
behavior somewhere else maybe?
Replace form.js with 3 files and update the references to the proper file in the rest of the code.
Comment | File | Size | Author |
---|---|---|---|
#8 | core-js-refactor-form-1685146-8-do-not-test.patch | 5.77 KB | nod_ |
#5 | 1685146-refactor-form-js.patch | 7.31 KB | rballou |
Comments
Comment #1
Kiphaas7 CreditAttribution: Kiphaas7 commentedBONUS: Investigate if adding basic events and detach makes sense, as described in #1763812: [META] Provide complete attach/detach with basic events.
Comment #2
nod_tag
Comment #3
rballou CreditAttribution: rballou commentedThe following modules use the summary functionality provided by `form.js`:
A couple questions regarding how to handle updating their library information:
Comment #4
nod_1. don't think so, i'd have to dig into but it's a small thing.
2. yes
:)
Comment #5
rballou CreditAttribution: rballou commentedSweet, figured out how the drupal.form bit worked :)
Anyway, here's an initial patch that: removes the summary jQuery code to it's own file,
core/misc/drupal.summary.js
; updates the system library info; updates the modules above so that there library info calls include the new file; and changes the bindings in the summary code to on/off calls. I have not rolled out any updates for the other two pieces of form.js code. Also I only addeddrupal.summary
as dependencies, I did not check if they code was using the other functionality and removedrupal.form
as needed.I currently have this code push out to github at: https://github.com/robballou/drupal/tree/8.x-form-js
Comment #6
nod_#5: 1685146-refactor-form-js.patch queued for re-testing.
Comment #8
nod_Just posting the code I have so far, needs some more work but it's a good re-start. The changes made in #5 are not included in this patch, but they should!
this patch will fix #1636992: form.js' formUpdated event is unreliable/incomplete and #1515734: form.js' 'formUpdated' behavior is slow because it binds to each element rather than delegating also, not closing yet, some people might complain about the scope creep :þ
This patch needs to be applied on top of #1705618-26: Double click prevention on form submission.
Comment #9
Wim LeersSo is #1636992: form.js' formUpdated event is unreliable/incomplete then a duplicate of this one?
In either case, this blocks #1636992, and #1636992 is critical, so marking this as critical.
Comment #10
nod_Comment #11
nod_Should have left that one as critical to get people working on it :þ
Comment #15
andypost