Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Subissue of #1787218: Convert testing variables to state system..
Change the variable xmlrpc_test_xmlrpc_alter to the state system.
Comment | File | Size | Author |
---|---|---|---|
#9 | 1848066-xmlprc_to_state-drupal8-9.patch | 1.9 KB | ACF |
#7 | 1848066-xmlprc_to_state-drupal8-7.patch | 18.91 KB | ACF |
#4 | 1848066-xmlprc_to_state-drupal8-4.patch | 1.89 KB | Gaelan |
#1 | 1848066-xmlprc_to_state-drupal8-1.patch | 1.88 KB | ACF |
Comments
Comment #1
ACF CreditAttribution: ACF commentedPatch attached.
Comment #2
gddThis needs a default value.
Otherwise looks fine.
Comment #3
gddI'm sorry I'm stupid. The state() system does not use default values like the variable system does. This needs to be converted to something like
I'd rather not put the ternary in the if but that's just me.
I also wouldn't mind seeing the name changed to 'xmlrpc_test.alter' because the second xmlrpc seems redundant.
Comment #4
Gaelan CreditAttribution: Gaelan commentedFixes concerns in #3.
Comment #5
Gaelan CreditAttribution: Gaelan commentedI am forgetful.
Comment #7
ACF CreditAttribution: ACF commentedAttached a patch with the changes requested.
I'm not sure why the state()->get needs a default value, as it was in the if statement and it will fail the conditional statement either with false or null?
Comment #9
ACF CreditAttribution: ACF commentedStupid mistake on the last patch.
Comment #10
aspilicious CreditAttribution: aspilicious commentedOk good to go!
Comment #11
webchickCommitted and pushed to 8.x. Thanks!