Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
These should pass on 7.x, and we can then backport to 6.x to hopefully fix #1798484: Product kit miscalcuation of discounts and total price changes every time saved
Comment | File | Size | Author |
---|---|---|---|
#12 | 1840260-kit-default-qty-d6.patch | 1.34 KB | longwave |
#11 | 1840260-kit-default-qty-11.patch | 2.77 KB | longwave |
#9 | 1840260-kit-default-qty.patch | 1.86 KB | longwave |
#9 | 1840260-kit-default-qty-tests-only.patch | 1.36 KB | longwave |
#7 | 1840260-uc_product_kit-tests-d6-7.patch | 11.06 KB | longwave |
Comments
Comment #1
longwaveCommitted.
Comment #2
longwaveI don't think this is going to prove what I expected it to prove.
Comment #4
longwaveThis should fix the above failures and exceptions. There's a handful of seemingly harmless warnings, but it does appear that the default quantity field on new product kits has never worked in 6.x, and looking at 7.x it seems we do the wrong thing there as well; I guess nobody uses this feature enough to notice.
Comment #6
longwaveHmm. That doesn't happen when I run the tests locally.
Comment #7
longwaveSo assertFieldByName() works slightly differently on select elements in D6 and D7.
Comment #8
longwaveCommitted #7. Back to active, to add more tests for default quantity.
Comment #9
longwaveComment #11
longwaveComment #12
longwaveCommitted #11.
Comment #13
longwaveCommitted #12.