Incorrect error message when poll is submitted with no option selected

I also faced the same issue with poll module. I think the issue is not because of the panels module. I faced the issue with out panels.

I think issue is due to #default_value set to -1 for $form['choice'] inside function poll_view_voting() at line 723 in poll module . When form is being build by drupal's form api there is a check that #default_value should be one from the options for that form element.

Fix:
In your custom module you can fix it by implementing hook_form_FORM_ID_alter as below

function MYMODULE_form_poll_view_voting_alter(&$form, &$form_state, $form_id) {
        // Unset the default value which is causing issue
	unset($form['choice']['#default_value']);
        
        // Define custom validate function to apply the validation 
	$form['#validate'][] = 'MYMODULE_form_poll_view_voting_validate';
}

function MYMODULE_form_poll_view_voting_validate($form, &$form_state){
  if (!isset($form_state['values']['choice'])) {
    form_set_error( 'choice', t('Your vote could not be recorded because you did not select any of the choices.'));
  }
}

Seems to be a poll issue - not a panels issue.

Attached is the patch against 7.x.

This needs to have automated tests added. See the instructions for creating automated tests.

Please review the attached patch for creating automated tests for this scenario.

Before applying the patch in #5, automated tests show 1 failure. After applying the patch in #5, automated tests show 0 failure.

Great work, amitgoyal. I just have a few notes for you.

+++ b/modules/poll/poll.test
@@ -315,6 +315,11 @@ class PollVoteTestCase extends PollTestCase {
+    $this->assertText('Your vote could not be recorded because you did not select any of the choices.', 'An illegal choice has been detected. Please contact the site administrator.');

'Your vote could not be recorded because you did not select any of the choices.' should be wrapped in the t() function, since it should be translated on the page where it appears.

'An illegal choice has been detected. Please contact the site administrator.' isn't an appropriate assertion message and can be changed to be more descriptive about the thing you're asserting, for instance 'Found the empty poll submission error message.' You probably knew this, but it should not be wrapped in t().

Finally, I'll need to see #5 and #8 combined into one patch in order to do a proper review.

combined patch of #5 and #10 with changes mentioned in #11.

Thank you for working on the combined patch. Unfortunately, your patch contains changes to your .gitignore file that were added by mistake.

sorry for the mistake. Updated the patch.
Please review now.

Alright! #14 is RTBC. The patch fixes the issue where the "Your vote could not be recorded..." error message did not appear when a poll is submitted without an option being selected.

Big thanks to everyone who helped work on this!

@David_Rothstein or any other core committer: the tests-only patch is in #9.

Committed to 7.x - thanks!