Imported metatags cannot be overriden [#1852022]

Scenario:

1. Export a sub-set of metatags into a feature.
2. Enable the feature in another database.
3. Attempt to override the sub-set >> values stay with the global ones.

The above occurs because the exported metatag configuration contains the cid ($conf->cid) but it is not saved in the database, so when the overriden configuration is about to be saved, metatag_config_save() sees that there is a $cid and calls drupal_write_record() for update.

I have seen that deleting the cid values at the feature fixes it, but wonder if removing the cid when exporting a feature may cause other side-effects.

Comment	File	Size	Author
#2	metatag-n1852022-2.patch	408 bytes	DamienMcKenna
#2
#1	metatag-cannot-override-imported-1852022-1.patch	791 bytes	juampynr
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

juampynr CreditAttribution: juampynr commented 27 November 2012 at 17:16

Status:

Active

» Needs review

File	Size
metatag-cannot-override-imported-1852022-1.patch	791 bytes

Here is a patch.

Comment #2

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 3 December 2012 at 15:39

File	Size
metatag-n1852022-2.patch	408 bytes

An alternative approach, this flags the 'cid' field to be not exportable; all exports will have to be updated to match, or you could just manually remove the 'cid' value from the exported files.