Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.After running the Coder module against Phone code many problems were found.
I'm opening this task in order to track and fix it.
Attached is a output from coder module with all changes that has to be made to the code fit Drupal code quality.
Comments
Comment #1
rfsbsbAttaching the file.
Comment #2
cweagansThis is important, but I think it's fairly low on the list of things to do for a 1.x release. Demoting.
Comment #3
rfsbsbI agree but as stated let's keep a track of it for future commits/releases.
Comment #4
rfsbsbFixing the typo in issue name.
Comment #5
rfsbsbHere's a patch to fix these items.
Nothing structural has changed, only coding style to fit Drupal code standards.
Comment #6
cweagansThe question to answer here is this: Is it worth breaking all of the other patches in the queue for coding standards? I don't think so. We really really shouldn't worry about this right now. There are approximately thirty patches in the needs review queue + the needs work queue that need to be reviewed/committed before this can go in.
I know that this is important, but I don't think it's so important that we need to break a bunch of other patches.
Comment #7
rfsbsbGot it.
I haven't thought in this impact when submitted the patch. I'll start reviewing patches next week before come back to this item.
Thank you for your clarification.