Metatag googlebot:unavailable_after is written when node is shown in a view, panel or block [#1781186]

The following metatag appears on our homepage:
<meta name="googlebot" content="unavailable_after: 11-Sep-2012 14:39:15 CEST" />

This is because we have a block on the homepage which uses node_view() to show full items in a slideshow.
scheduler_node_view() doesn't check if we're on a node detail page and prints out the metatag also on the homepage.

I suggest the following change:
change

if ($view_mode == 'full' && !empty($node->unpublish_on)) {

if ($view_mode == 'full' && !empty($node->unpublish_on) && count(arg()) === 2 && arg(0) === 'node' && is_numeric(arg(1))) {

So this metatag is only printed out on detail pages, not when a page uses node_view() somewhere.

Comment	File	Size	Author
#3	_scheduler.1781186_3.unavailable_after.patch	909 bytes	jonathan1055
#3
#2	_scheduler.1781186_2.unavailable_after.patch	759 bytes	jonathan1055
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jonathan1055 CreditAttribution: jonathan1055 commented 2 December 2012 at 12:39

Hi pcoucke,
Yes I can see this is a problem. Can you give me an example of your code, or show how I can replicate the full node view when it is not the node's page. Then I can test your fix and make a patch.

The function node_is_page($node) might be a more readable way to determine it, but until I can replicate your code I can't test it.

Jonathan

Comment #2

jonathan1055 CreditAttribution: jonathan1055 commented 2 December 2012 at 14:55

Status:

Active

» Needs review

File	Size
_scheduler.1781186_2.unavailable_after.patch	759 bytes

I found a way to test it, by simply having a page which executed php that called node_view. The function node_is_page() works nicely, and here is a patch for you to try.

Jonathan

Comment #3

jonathan1055 CreditAttribution: jonathan1055 commented 18 April 2013 at 16:29

File	Size
_scheduler.1781186_3.unavailable_after.patch	909 bytes

A further check is required to make sure the node is not being edited. Although it does not matter if the temporary edit page has the 'unavailable after' info in the header, it has caused problems adding it during the preview, hence a simple check on arg(2) != 'edit' avoids this.

Also to prevent confusion, I have changed it to use $node->scheduler['unpublish_on'] which is always numeric. $node->unpublish_on is numeric in saved nodes but is a string during editting. Hence better to use the consistent one.

This patch now also solves issue #1036296: Previewing a scheduled node will result in PHP warnings

Jonathan

Comment #4

jonathan1055 CreditAttribution: jonathan1055 commented 17 April 2013 at 20:21

Hi pcoucke

Have you managed to test the patch? If you need help to apply the patch let me know.

To test the fix, you can paste this into an 'Execute PHP' form, if you are using the Devel module

$query = db_select('scheduler', 's');
$query->addField('s', 'nid');
$query->condition('s.unpublish_on', 0, '>');
$queryResult = $query->execute();
$output = '';
while ($n = $queryResult->fetchObject()) {
  $node=node_load($n->nid);
  node_view($node);
  $output .= 'node ' . $node->nid . ' = ' . l($node->title,'node/' . $node->nid)
    . '<br>node_is_page(' . $node->nid .') = ' . (node_is_page($node) ? ' TRUE ' : 'FALSE')
    . '<br>unpublish on = ' . format_date($node->scheduler['unpublish_on']) . '<br><br>';
}
drupal_set_message($output);

We would like to get this fix committed to scheduler 7.x-1.1 soon, then also port it to the Drupal 6 version.

Jonathan

Comment #5

pcoucke CreditAttribution: pcoucke commented 18 April 2013 at 10:47

I just tested again and the patch from #3 works!

Comment #6

jonathan1055 CreditAttribution: jonathan1055 commented 18 April 2013 at 16:33

Title:	metatag googlebot:unavailable_after is written out on homepage	» Metatag googlebot:unavailable_after is written when node is shown in a view, panel or block
Status:	Needs review	» Reviewed & tested by the community

Thanks for confirming this. I'm marking as Reviewed and tested, so that Rick can commit this patch when he next does a batch of updates.

Jonathan

Comment #7

rickmanelius CreditAttribution: rickmanelius commented 20 April 2013 at 02:46

Version:	7.x-1.0	» 7.x-1.x-dev
Status:	Reviewed & tested by the community	» Fixed

Committed. http://drupalcode.org/project/scheduler.git/commit/3f30383

Thanks pcoucke and jonathan1055!

Comment #8

jonathan1055 CreditAttribution: jonathan1055 commented 22 April 2013 at 07:16

I have checked in Drupal 6 and there is no problem, it already works correctly. The code in scheduler_nodeapi() is:

 elseif ($op == 'view') {
    if (isset($a4) && $a4 && isset($node->unpublish_on) && $node->unpublish_on) {
      $unavailable_after = date("d-M-Y H:i:s T", $node->unpublish_on);
      drupal_set_html_head('<meta name="googlebot" content="unavailable_after: '. $unavailable_after .'" />');
    }
  }

The parameter $a4 is always blank during edit and preview and also blank when the node is displayed in teaser mode. It is only 1 when displaying the node in full page view on its own page. So backport to Drupal 6 is not required.