The term Bar appears as an open graph type and the translation machinery gets it wrong, at least for Danish, where the term bar (a place to drink) is a very different word than the default Drupal "bar" (a visual element like a bar chart).

So to not confuse non-english users it would be nice with a string context in the opengraph translation of the term (metatag_opengraph/metatag_opengraph.metatag.inc), so translator can distingues.

/Anton

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

I'm fairly new to dealing with translations, would you mind either providing a patch, explaining what needs to be done or providing a link to documentation on how to do this? Thanks.

DamienMcKenna’s picture

String context info: http://drupal.org/node/1369936

DamienMcKenna’s picture

Status: Active » Needs review
FileSize
568 bytes

Would this work? I've added a the context "location".

DamienMcKenna’s picture

FileSize
971 bytes

I've changed it to 'business', added the same context to the other businesses and then also added a new context to some of the other strings.

DamienMcKenna’s picture

FileSize
2.66 KB

Forgot to hit save before creating the patch.

Dave Reid’s picture

Is there some kind of unified way to know what value to use for context? For example: band is music and not noun? Maybe we should standardize all of these and use a context of 'OpenGraph type' instead since that's truly the context being used?

Dave Reid’s picture

Status: Needs review » Needs work
Gábor Hojtsy’s picture

Dave: there is no clear consensus in #1035716: [policy, no patch] Decide and document guidelines for using string context but that is the issue for the discussion you are referring to. I agree things like Bar and Band are very ambiguous and would need context provided.

DamienMcKenna’s picture

@Gábor: Thanks for chiming in. Any suggestion on what should be used in this situation as the context for "bar"?

DamienMcKenna’s picture

Issue tags: +string context

Tag.

Sutharsan’s picture

First, and foremost: A context is only required when a translation conflict exists. Don't add contexts for potential conflicts. This issue was opened for a conflict on 'bar', unless there have been (non-documented) discussion with stonor, please remove all contexts except for 'bar'.

My first guideline for contexts is that a context describes the linguistic meaning in its context. My suggestions for 'Bar' context this case: 'an establishment' or (popular) 'where beer is served'.

DamienMcKenna’s picture

Issue summary: View changes
Status: Needs work » Needs review
FileSize
567 bytes

@Sutharsan: thanks for your help. I've updated the patch to use "an establishment", as suggested, and removed the other contexts.

DamienMcKenna’s picture

Status: Needs review » Fixed

Committed. Thanks for your help, everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.