Installation in non-English language fails

What's happening is that st() is called very early in the install process, by Drupal\Core\Database\Install\Tasks::runTestQuery().

But, in the presence of installing from a translation, st() calls:
- drupal_get_path() which calls drupal_get_filename() which expects drupal_container() to already exist, but it doesn't yet.
- Even if you fix the above with ($container = drupal_container()) && $container->has(...), you then run into a problem that st() also calls Gettext::filesToArray() which calls PoStreamReader::open() which calls drupal_realpath() which requires various subsystems to already be bootstrapped in order to deal with file stream wrappers.

So, I'm guessing we need to either make runTestQuery() not call st(), or else fix st() to not invoke these various functions when this early in the install process.

Converting runTestQuery to format_string is quite probably quick and easy. It's a whole another question whether we are happy with the nontranslateability of those strings. I think fixing the whole path is better. ($container = drupal_container()) && $container->has(...), is something I wanted to do anyways and

> PoStreamReader::open() which calls drupal_realpath()

Well that looks a particularly bad idea to me, didnt we say to call drupal_realpath only in utmost need? I recall there was an issue saying so. Did it not make into the docs? Looking at the code, fopen(drupal_realpath($this->_uri), 'rb'); wtf is that and why you can't do fopen($this->_uri, 'rb'); ??? fopen supports wrappers just fine.

Let's see what bot thinks. The drupal_realpath() was added in #1658842: Introduce a translations:// stream wrapper to access the .po file directory. I added a comment there linking to here.

Now we just need someone to manually test the scenario described in #0 and we are good to go. That is a very easy thing to do because of the high quality report Sutharsan filed so I tag this step Novice. If it fixes the problem , please RTBC.

without the patch:

sudo rm -r sites
git checkout sites
drush -y sql-drop --db-url="mysql://root:root@localhost/d8-patch"
git pull --rebase
git reset --hard
mkdir sites/default/files
mkdir sites/default/files/translations
cd sites/default/files/translations
curl -O http://ftp.drupal.org/files/translations/7.x/drupal/drupal-7.17.nl.po

1. pick nederlands

2. see other language, proceed with install

3. enter db info

4. white screen

I do not get the error "Call to a member function has() on a non-object in /Users/erik/www/drupal8/core/includes/bootstrap.inc on line 902"

but it does white screen!

test the patch

drush sql-drop
cd ../../../..
sudo rm -r sites
git checkout sites
git pull --rebase
git reset --hard
git checkout -b install-1864292-3
curl -O http://drupal.org/files/installer-mi.patch
git apply --index installer-mi.patch
git commit -m "3 patch"
mkdir sites/default/files
mkdir sites/default/files/translations
cd sites/default/files/translations
curl -O http://ftp.drupal.org/files/translations/7.x/drupal/drupal-7.17.nl.po

steps are the same as without the patch for 1. 2. 3.

4. Get different error
at core/install.php?langcode=nl&profile=standard

In order for Drupal to work, and to continue with the installation process, you must resolve all issues reported below. For more help with configuring your database server, see the installation handbook. If you are unsure what any of this means you should probably contact your hosting provider.

Failed to CREATE a test table on your database server with the command CREATE TABLE {drupal_install_test} (id int NULL). The server reports the following message: SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'drupal_install_test' already exists: CREATE TABLE {drupal_install_test} (id int NULL); Array ( ) .

Are you sure the configured username has the necessary permissions to create tables in the database?

Next

hmm. test again: maybe a totally new everything? git clone and a new db too?

the drush sql-drop I did to test the patch did not drop the tables.

repeated with
drush -y sql-drop --db-url="mysql://root:root@localhost/d8-patch"
and verified the db was empty

install goes same as without the patch for 1. 2. 3.

Then 4. proceeds

5. goes to 100% and then warning
at
core/install.php?langcode=nl&profile=standard

Warning: Invalid argument supplied for foreach() in locale_translation_status_delete_languages() (line 949 of core/modules/locale/locale.module).

6. install finishes ok.

So manual test result: patch gets the install past the white screen.

follow-up
#1864472: Warning when tries to delete English after non-English install, locale_translation_status_delete_languages()

In #1658842-61: Introduce a translations:// stream wrapper to access the .po file directory, looks like the drupal_realpath() was added because of suspected PHP versions / OS not supporting stream wrappers directly, but PHP's documentation of fopen() states that it supports stream wrappers. So, given that, and the testing above, RTBC.

[Edit: oops, I didn't notice this was already RTBC'd earlier. Thanks!]

Looks good. Committed/pushed to 8.x.