Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I have no idea what this functionality does, what I do know is that the text can be better, I have rewritten it so it only uses the label.
Comment | File | Size | Author |
---|---|---|---|
#27 | drupal-1837998-27.patch | 1.66 KB | David Hernández |
#20 | drupal-1837998-20.patch | 1.46 KB | dawehner |
#20 | interdiff.txt | 812 bytes | dawehner |
#13 | vdc-1837998-13.patch | 1.55 KB | xjm |
#13 | embed_display.png | 13.69 KB | xjm |
Comments
Comment #1
Bojhan CreditAttribution: Bojhan commentedComment #3
Bojhan CreditAttribution: Bojhan commented#1: drupal.core_.settingsscreentext.1837998.patch queued for re-testing.
Comment #4
dawehnerWell ... in fact you can use the embed display without this checkbox (it's just not visible in the UI), but yeah, for the normal user
don't have to know / don't want to know.
Comment #5
dawehnerSo i think the new text is okay even it's not really the truth.
Comment #6
xjmI don't understand the new text either. Also, "allow using" is awkward.
Comment #7
dawehnerWhat about keeping the #title from now and skip the description?
Comment #8
xjmI think what we need is something like:
I am trying to understand why this is a setting at all, and what it's for.
Drupal\views\Plugin\views\display\Embed
is, like, empty.Comment #9
xjmEssentially, there is nothing that tells the user what an "embed display" is. Or me.
Comment #10
Bojhan CreditAttribution: Bojhan commentedI don't get this setting either, honestly - I just figured it sounded weird.
Comment #11
dawehnerThere are reasons we try to hide this from the user :)
It's doing nothing specia! You have a separated display which you can embed using php. All other display plugin types does someone additional, which you don't want in pure php code.
Comment #12
xjmMaybe:
That's an awful lot of text, but we need to explain what it is somehow. A big problem here is that the views term "display" is exactly what it isn't semantically in this case. ;)
Comment #13
xjmLet's try this. I removed some of the other mostly-redundant descriptions so there's less text to read in this section, but included a description for this option.
Comment #14
dawehnerYou seem to know that you shouldn't put "." at the end of the sentence. At least for me this new texts would help.
Comment #15
tim.plunkettSpeaking of which.
Comment #16
Dries CreditAttribution: Dries commentedLet's see what Bojhan thinks.
Comment #17
catchComment #18
Bojhan CreditAttribution: Bojhan commentedWe cleaned it up a lot, thanks xjm! However this could probably be a bit better, since its not common to have a checkbox that says "Configure X in the UI" and it could probably be shorter. What about:
"Allow embedded displays"
Embedded displays are code-only displays, often used by modules to do X.
I guess, you don't actually allow it? But we should probally say something along the lines of a "Show" or "Allow" - having it be "Configure X in the UI" is a bit confusing, because its so uncommon.
Comment #19
Bojhan CreditAttribution: Bojhan commentedComment #20
dawehnerWhat about showing the user how to actually use embed displays?
Comment #21
xjmHmm, I'm not sure that's a good idea. The audience of UI helper text is not developers.
Comment #22
tim.plunkettWell, the point is that the embed display is only useful when using views_embed_view() anyway...
I like it.
Comment #23
damiankloip CreditAttribution: damiankloip commentedI think the helper text can be for developers too, why not?! Developers do use Drupal too, sometimes... :) What if you have more of a 'dabbling' developer... this would be a good guide I think.
I'm also not sure why we are removing all the description text, this makes the options sound more vague than before. Which I would say is less helpful. For example, "Always show the master (default) display" is not that indicative of what it does. We lose the where and the why.
Comment #24
Bojhan CreditAttribution: Bojhan commented@damiankloip Agreed, lets work on it some more. Its natural though, sometimes we cut too much and often not enough :)
Comment #25
damiankloip CreditAttribution: damiankloip commentedOpened #1882114: Remove listing filters option from views settings earlier, this removes another option, which I guess helps :)
Comment #26
dawehnerComment #27
David Hernández CreditAttribution: David Hernández commentedRe-rolled
Comment #28
dawehnerNice!
Comment #29
webchickCommitted and pushed to 8.x. Thanks!