Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The attached patch corrects a few minor inconsistencies with the use of @link...@endlink in some core code files, specifically,
core/includes/database.inc
core/lib/Drupal/Core/Ajax/ReplaceCommand.php
core/modules/field/field.api.php
core/modules/system/system.api.php
Comment | File | Size | Author |
---|---|---|---|
#12 | fix-link-endlink-inconsistencies-1864360-12.patch | 624 bytes | oadaeh |
#6 | fix-link-endlink-inconsistencies-1864360-6.patch | 2.42 KB | oadaeh |
#2 | fix-link-endlink-inconsistencies-1864360-2.patch | 1.72 KB | oadaeh |
fix-link-endlink-inconsistencies.patch | 3.27 KB | oadaeh | |
Comments
Comment #1
jhodgdonBy my count, the lines you rewrapped in field.api.php and system.api.php were 80 characters before and do not need rewrapping?
The rest of the patch looks good though, thanks!
Comment #2
oadaeh CreditAttribution: oadaeh commentedMy editor was telling me they were 81 characters, but I guess it was telling me about the next character, not the current one. I'll have to pay better attention to that.
Comment #3
jhodgdonThanks! That patch looks great to me.
Comment #4
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks!
Comment #5
jhodgdonProbably some of this should be backported to d7?
Comment #6
oadaeh CreditAttribution: oadaeh commentedLooks like all of them came from D7 that way. I also found another one.
Comment #7
jhodgdonLooks good, thanks! That one additional place you found in d7 -- does it exist in d8 also? If so, we should fix it in d8 before proceeding to d7 (or at least do a follow-up patch after this is committed).
Comment #8
oadaeh CreditAttribution: oadaeh commentedWhen I found it in D7, I went and checked the D8 version, and it was correct.
Comment #9
jhodgdonThanks!
Comment #10
David_Rothstein CreditAttribution: David_Rothstein commentedCommitted to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/8ec1f07
Comment #11
David_Rothstein CreditAttribution: David_Rothstein commentedActually, the change to includes/ajax.inc needs to go into Drupal 8 too.
Comment #12
oadaeh CreditAttribution: oadaeh commentedSorry about that. I thought I got that one.
Comment #13
jhodgdonThanks!
Comment #15
jhodgdon#12: fix-link-endlink-inconsistencies-1864360-12.patch queued for re-testing.
Comment #16
jhodgdonThat was some kind of a test bot glitch ("Failed to get list of tests to run" or something like that).
Comment #17
jhodgdonCommitted to 8.x. I think this issue is done now -- thanks oadaeh!
Comment #19
oadaeh CreditAttribution: oadaeh commented