Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
API page: http://api.drupal.org/api/drupal/core%21modules%21overlay%21overlay.modu...
The documentation says:
Requests that the overlay overlay closes when the page is displayed.
The sentence should be:
Requests that the overlay closes when the page is displayed.
Alternatively, it could be:
Requests the overlay closes when the page is displayed.
Comment | File | Size | Author |
---|---|---|---|
#3 | repeated-word-1868206-3.patch | 514 bytes | apaderno |
#1 | repeated-word-1868206-1.patch | 509 bytes | apaderno |
Comments
Comment #1
apadernoComment #2
jhodgdonI think we need the word "that" in there actually. The patch's wording does not make sense to me.
Comment #3
apadernoIt makes sense in the same way "She requests you are in time." does. (We could debate using the subjunctive mood, as it is a request.)
Looking at what the NOAD says, I would think that is not necessary, in this case.
In "requests that the overlay closes when the page is displayed," "the overlay closes when the page is displayed" is a subordinate clause, in the same way "she was satisfied" is in "she said she was satisfied."
Anyway, this is the patch that uses that.
Comment #4
apadernoComment #5
jhodgdonI don't know about NOAD, but without "that" the documentation doesn't make any sense to me (and I'm a native speaker of American English). "She said she was satisfied" does make sense to me and sounds natural, but the docs example doesn't work. Sometimes grammar rules just don't get the whole picture of a living language as it actually is, alas!
Anyway, that patch works for me. Thanks!
Comment #6
webchickCommitted and pushed to 8.x and 7.x. Thanks!