Ref: http://blog.jquery.com/2012/08/09/jquery-1-8-released/
jQuery core 1.8.0 is compatible with the latest versions of jQuery UI (1.8.22), and jQuery Mobile (1.1.1).
Even though it doesn't say its NOT compatible but it is not compatible.
So if we enable jquery core 1.8 through jquery update the ui would be still at 1.8.11. Jquery ui 1.8.11 is not compatible with jquery 1.8 due to deprecated curCss function. So i suggest jqery_update also ship with an option to include jquery ui 1.8.22 atleast.
I would have marked this as feature request. But it creates some issues due to the above mentioned incompatibility ( for example it breaks ctools modal popups). So marking this is a bug.
Comment | File | Size | Author |
---|---|---|---|
#19 | jquery_update-ui_1.8.24-1847900-19.patch | 1.58 MB | hswong3i |
#13 | jquery_update-ui_update-1847900-13.patch | 681.2 KB | marcvangend |
#7 | jquery_update-ui_update-1847900.patch | 681.24 KB | rwinikates |
#4 | 1847900-bump-query-ui.patch | 690.35 KB | wiifm |
Comments
Comment #1
D34dMan CreditAttribution: D34dMan commentedsorry reported this issue in wrong branch... now its ok.
Comment #2
D34dMan CreditAttribution: D34dMan commentedI also noticed that instead of giving different version upgrading ( i replaced all the files ) jquery ui to 1.8.22 solves the issue.
Comment #3
wiifmBumping priority as using jQuery 1.8 now should be bundled with jQuery UI 1.9
Error message when trying to use jQuery UI draggable:
There is a bug on jQuery about this, which is closed, as it is fixed in jQuery 1.9.0.
Anyone know any workarounds, or should one simply hack the new version in here?
Comment #4
wiifmHere is a patch to update jQuery UI to 1.8.24 which also resolves my issue with 'curCSS'
Comment #5
darrenmothersele CreditAttribution: darrenmothersele commentedThank you. The patch in #4 resolves the curCSS error I was getting from the Media module media browser popup.
Comment #6
redben CreditAttribution: redben commentedPerfect. Thanks wiifm
Comment #7
rwinikates CreditAttribution: rwinikates commentedPatch in #4 works if using local jquery, not if using CDN, so I subsumed that patch into mine which also increments the versions grabbed via CDN:
Comment #8
D34dMan CreditAttribution: D34dMan commentedChanging the status since a new patch was uploaded in previous comment.
Comment #9
rickmanelius CreditAttribution: rickmanelius commentedWhile I'm not going to do a line by line review of all the plugins... I did apply the patch and everything is working as expected. Also, the CDN edits looks right.
If you want more reviews before committing, no worries.
Comment #10
betz CreditAttribution: betz commentedI can confirm that this patch fixes the 'curCSS' issue.
Comment #11
timbrandin CreditAttribution: timbrandin commented#1847900-7: Update jQuery UI to 1.8.24 has a couple trailing space errors when I applied it, but otherwise it helpes with ctools and media module.
These errors:
jquery_update-ui_update-1847900.patch:2225: trailing whitespace.
});
jquery_update-ui_update-1847900.patch:2305: trailing whitespace.
'ج',
jquery_update-ui_update-1847900.patch:2314: trailing whitespace.
'ج',
jquery_update-ui_update-1847900.patch:3260: trailing whitespace.
'ج',
jquery_update-ui_update-1847900.patch:3269: trailing whitespace.
'ج',
warning: squelched 24 whitespace errors
warning: 29 lines add whitespace errors.
Comment #12
timbrandin CreditAttribution: timbrandin commentedChanging status, because the whitespace problems is causing a lot of output when building the site through drush.
Comment #13
marcvangendHere is the same patch as in #7, but with all whitespace errors solved. (Yay! for regex search and manually editing patch files :-))
If it works for you like it does for me, I guess we can set this back to RTBC.
Comment #14
D34dMan CreditAttribution: D34dMan commentedSo lets review it then :)
Comment #15
queenvictoria CreditAttribution: queenvictoria commentedWorks for me.
Comment #16
rokk CreditAttribution: rokk commentedAlso works for me. You should use
7.x-2.x-dev
version.Comment #17
marcvangend@rokreativa: yes, that's why this issue says "Version: 7.x-2.x-dev".
Given the positive feedback and the fact that this was RTBC before I fixed the whitespace errors in the patch, I'm setting this to RTBC again.
Comment #18
damontgomery CreditAttribution: damontgomery commented#1847900-13: Update jQuery UI to 1.8.24 seems to work great for me.
My issue was specific to Media 2.x
Thanks!
Comment #19
hswong3i CreditAttribution: hswong3i commentedPlease kindly correct me:
Patch recreate with following procedures, so should include both #13 progress for CDN + replace all possible jquery-ui files as version 1.8.24:
Assume replace all jquery-ui's file as 1.8.24 is correct, this patch should coming with identical effect as that of #13. If this works as expected we should safely switch back as RTBC ;-)
Comment #20
hswong3i CreditAttribution: hswong3i commented@marcvangend: how do you solve the whitespace errors at #13? I try numbers of way but still fail for #19 :-(
Comment #21
marcvangendhswong3i, I opened the patch file in a text editor (UTF-8 supporting, running on Linux - not sure if that matters here) and looked up the line numbers that git complained about. It turned out that those lines were doing weird things with spaces, tabs and non-latin characters that I don't understand. I removed trailing spaces and adjusted the indents to match the lines before and after.
Comment #22
ericduran CreditAttribution: ericduran commentedSo there's no need to support 1.8.24. Since there is now a 1.10.2 version. I'm trying to close all the UI related issues and merge them into one issue.
The issue is #1947438: Update jQuery UI to the latest version (1.10.2).
Comment #22.0
ericduran CreditAttribution: ericduran commentedFixed a typo.