Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Here is a patch. Let me know what you think!
Comment | File | Size | Author |
---|---|---|---|
#16 | ctools_comment_panels-1693352-14.patch | 7.63 KB | osopolar |
#10 | comment_panels-1693352-10.patch | 7.63 KB | pfaocle |
#5 | 0001-Adding-comment-reply-as-ctools-task 1.patch | 8.17 KB | pwaterz |
#3 | 0001-Adding-comment-reply-as-ctools-task.patch | 16.98 KB | pwaterz |
#2 | 0001-Adding-comment-reply-as-ctools-task.patch | 8.21 KB | pwaterz |
Comments
Comment #1
pwaterz CreditAttribution: pwaterz commentedFound a bug, new patch
Comment #2
pwaterz CreditAttribution: pwaterz commentedFixing another issue :)
Comment #3
pwaterz CreditAttribution: pwaterz commentedMade some more changes.
Comment #4
phayes CreditAttribution: phayes commentedMarking as needs review. We've tested it and it works.
Comment #5
pwaterz CreditAttribution: pwaterz commentedCleaned up the patch a bit
Comment #7
phayes CreditAttribution: phayes commented#5: 0001-Adding-comment-reply-as-ctools-task 1.patch queued for re-testing.
Comment #9
drupalerocant CreditAttribution: drupalerocant commentedAny conclussion to this? Is the patch committed? Can we use it safely?
Comment #10
pfaocleThanks for this patch! I've amended comment_reply_form.inc a little to avoid some warnings (checking $comment object) and also refer to $context[0] for the ..._admin_title:
Comment #11
pfaocleComment #12
pwaterz CreditAttribution: pwaterz commentedThe patch works. We have been using it for a while now.
Comment #13
iamcarrico CreditAttribution: iamcarrico commentedI can also confirm that this patch works as expected.
I have not gone line by line to ensure the code is right, just confirming functionality.
When the patch is applied--- ensure that there is a newline added to the end of the file. Drupal coding standards ftw.
Comment #14
merlinofchaos CreditAttribution: merlinofchaos commentedCommitted and pushed. Thanks for the patch!
Comment #15
pwaterz CreditAttribution: pwaterz commentedWoo!
Comment #16
osopolar'No context' is translateable. So it should be t('No context'):
I modified the patch.
Comment #17
pwaterz CreditAttribution: pwaterz commented#5: 0001-Adding-comment-reply-as-ctools-task 1.patch queued for re-testing.
Comment #18
neRok CreditAttribution: neRok commentedNot sure if I should start a new issue of post here, but I have just updated to the latest Ctools dev to test this out. When I Add Content > Comment > Comment Reply Form, the output is the same as the standard comment form, with the node or comment you are replying to above the form itself. There should be an option to disable the node/comment view, so I can output just the form.
For example, I may want the form itself on the right, and the node/comment view on the left. The current panel is just lumping everything together. The current panel may be better called "Rendered Comment Reply Page" or something of that effect, and a new form-only panel added.
Comment #19
pwaterz CreditAttribution: pwaterz commentedWhat this does is allow you to convert the comment page to a panel. If you would like more layers of abstractions, I invite you to submit a patch with more ctools content types with it broken apart.
Comment #20
phayes CreditAttribution: phayes commented@osopolar,
You should create a new issue for the above problem. This has already been merged and fixed.