Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chi’s picture

Status: Active » Needs review
FileSize
1.1 KB
jhodgdon’s picture

Status: Needs review » Needs work

That is true, thanks for reporting this issue! This "hook" [it's not really a hook in the normal sense -- it's only for profiles] is called from
http://api.drupal.org/api/drupal/core--includes--install.core.inc/functi...
and it definitely passes in $install_state when it does:

   $function = $install_state['parameters']['profile'] . '_install_tasks';
    if (function_exists($function)) {
      $result = $function($install_state);

However, I'm not happy about the documentation line that is added. The hook that is being documented here just lists the tasks. Saying "This is passed along to each task, so it can be modified if necessary." doesn't make sense here, I think?

cweagans’s picture

Issue tags: +Needs backport to D7
Albert Volkman’s picture

Status: Needs work » Needs review
FileSize
985 bytes

I agree.

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, thanks!

webchick’s picture

Status: Reviewed & tested by the community » Needs work

We need the datatype here, if I'm not mistaken.

Albert Volkman’s picture

Status: Needs work » Needs review
FileSize
991 bytes

Datatype'd.

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community
jhodgdon’s picture

Status: Reviewed & tested by the community » Fixed

Thanks! Committed to 8.x and 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.