Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Security Advisory follow-up
This tag is to be applied to issues where an official security release has been made, but the fix needs to be ported to the development version of the code.
Needs backport to D7
After being applied to the 8.x branch, it should be considered for backport to the 7.x branch. Note: This tag should generally remain even after the backport has been written, approved, and committed.
Also tagging as a release blocker for the next D7 release (just in case it turns out there's anything in the latest 7.x-dev code we need to do as followup for this, although I doubt it).
Comments
Comment #1
gregglesWell, probably some other metadata is important.
Comment #3
tim.plunkett57404_null_byte_file_munge_filename_17-D8.patch queued for re-testing.
Comment #4
David_Rothstein CreditAttribution: David_Rothstein commentedAlso tagging as a release blocker for the next D7 release (just in case it turns out there's anything in the latest 7.x-dev code we need to do as followup for this, although I doubt it).
Comment #6
plach57404_null_byte_file_munge_filename_17-D8.patch queued for re-testing.
Tests pass here.
Comment #7
plachThis is a straight port of the D7 patch. Tests pass, angels sing. RTBC :)
Comment #8
webchickCommitted and pushed to 8.x, but we need test coverage for this.
Comment #9
David_Rothstein CreditAttribution: David_Rothstein commentedMaybe just something like this?
Comment #11
David_Rothstein CreditAttribution: David_Rothstein commentedHm, I don't claim to have tested those myself actually, but I thought I at least ran them through
php -l
to check for syntax errors. Apparently not :)These should be better.
Comment #12
plachThe test looks good to me, but what about appending it to another test method to save a new drupal installation and speed things up a bit?
Comment #13
plachDidn't mean to change the status (yet :).
Comment #14
David_Rothstein CreditAttribution: David_Rothstein commentedWell, that entire file basically uses the one-test-per-method pattern already, so I didn't want to break the pattern here.
Comment #15
plachSound good.
Comment #16
webchickLovely. Thanks, David!
Committed and pushed to 8.x.
Those tests should be backported to 7.x too, methinks.
Comment #17
plachStraight reroll.
Comment #19
plachCool
Comment #20
David_Rothstein CreditAttribution: David_Rothstein commentedCommitted to 7.x - http://drupalcode.org/project/drupal.git/commit/aecf889
Comment #21
David_Rothstein CreditAttribution: David_Rothstein commentedI'm also 100% convinced that there's nothing left to do on 7.x-dev for this issue, so removing tag.