In node_feed() function we have assignment, results of which is unused:
$teaser = ($item_length == 'teaser');

CommentFileSizeAuthor
#3 1886876-3.patch505 bytesswentel
#1 remove-unused-assignment-1886876.patch494 bytesIRuslan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

IRuslan’s picture

IRuslan CreditAttribution: IRuslan commented
FileSize
remove-unused-assignment-1886876.patch494 bytes

Patch is added.

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Version: 7.x-dev » 8.x-dev
Status: Needs review » Needs work
Issue tags: +Needs backport to D7

Patch looks good but this needs fixed in d8 first.

swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
1886876-3.patch505 bytes

D8 version

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Needs review
marcingy’s picture

marcingy CreditAttribution: marcingy commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Needs review

Yep. Committed/pushed to 8.x.

dcam’s picture

dcam CreditAttribution: dcam commented

#1: remove-unused-assignment-1886876.patch queued for re-testing.

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs review » Reviewed & tested by the community

It's the same basic patch that was applied to D8. It looks alright to me. I'm setting this as RTBC.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/d0bc57b

Automatically closed -- issue fixed for 2 weeks with no activity.