hey there,

I noticed that answering quizzes was throwing an error:
Fatal error: Call to undefined function userpoints_get_vid

that's because I had disabled the Userpoints module without ticking off Enable UserPoints Module Integration in admin/quiz/settings/config (under Addons Configuration).

when I tried to un-check that option, it was greyed out as enabled.

now I understand module dependencies can be quite complicated, but I think it'd be friendlier if that particular checkbox were disabled automatically if the Userpoints module were disabled as well. or the quiz in question could call drupal_set_message() and warn site admins without a WSOD.

what do you think?

cheers,
Luciano

CommentFileSizeAuthor
#3 1889222_add_userpoint_to_term_3.patch5 KBSivaji_Ganesh_Jojodae
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

luco’s picture

luco CreditAttribution: luco commented
Category: bug » feature

... actually the code is working fine.

I checked line 2420 and it reads:
if ($quiz->has_userpoints etc.

so I looked into the DB table quiz_node_properties and there's a column has_userpoints which registered 1 for every quiz created while Userpoints integration was on, and 0 otherwise.

it means the actual problem is that there's no Userpoints integration checkbox for each quiz. at least I looked it over a few times and couldn't find it.

can we have that checkbox implemented?

thanks in advance.

Sivaji_Ganesh_Jojodae’s picture

Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commented
Version: 7.x-4.0-alpha12 » 7.x-4.x-dev
Category: feature » bug

I will add function_exists check before making call to userpoints api. Checkbox to enable user points per quiz is already there but not properly organized. Will add a separate vertical tab for this. Also it would be nice to be able to assign points to specific category.

Sivaji_Ganesh_Jojodae’s picture

Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commented
Status: Active » Fixed
FileSize
1889222_add_userpoint_to_term_3.patch5 KB

Fixed the issue and also have attached the patch to this comment.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit ef7172f on 7.x-4.x, 7.x-5.x by sivaji: 
    Issue #1889222 by luco: Fixed Userpoints integration settings error.

  • Commit ef7172f on 7.x-4.x, 7.x-5.x, quiz-pages by sivaji: 
    Issue #1889222 by luco: Fixed Userpoints integration settings error.

  • Commit ef7172f on 7.x-4.x, 7.x-5.x, quiz-pages, 2269219 by sivaji: 
    Issue #1889222 by luco: Fixed Userpoints integration settings error.

  • Commit ef7172f on 7.x-4.x, 7.x-5.x, 2269219 by sivaji: 
    Issue #1889222 by luco: Fixed Userpoints integration settings error.