Performance problem in _views_fetch_data, multiple unnecessary cache rebuilds [#1889198]

The patch introduced in #1421844: views_fetch_data() cache item can reach over 10mb in size has a bug that produces a full cache rebuilds when you ask for an specific table cache data for which views cannot get any data.

In a current project this bug is causing that saving some big views takes +4 minutes.

I think it is safe to assume that if we didn't get cache data for a table at the first rebuild we are not going to get it in the next.

Comment	File	Size	Author
#1	1889198-views-cache-rebuild.patch	612 bytes	Pedro Lozano
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Pedro Lozano CreditAttribution: Pedro Lozano commented 15 January 2013 at 14:18

Status:

Active

» Needs review

File	Size
1889198-views-cache-rebuild.patch	612 bytes

This patch solves the problem and I think it doesn't cause any side effects.

Comment #2

dawehner

German

CreditAttribution: dawehner commented 15 January 2013 at 23:16

Status:

Needs review

» Reviewed & tested by the community

This is looking pretty good, and similiar to Drupal 8 :)

Comment #3

Pedro Lozano CreditAttribution: Pedro Lozano commented 16 January 2013 at 02:59

Posted a patch for D8 at #1889810: Performance, unnecessary views cache rebuilds.

Comment #4

andrewbelcher CreditAttribution: andrewbelcher commented 16 January 2013 at 13:24

I can confirm that this solved the problem. Attempting to clear caches was timing out for me, and even drush was taking more than 10 minutes just for a cc menu. With this patch it took seconds. This would be a really helpful patch to have committed!

Comment #5

dawehner

German

CreditAttribution: dawehner commented 16 January 2013 at 14:05

My question is: Why does something asks for a views table which does not exist?
One example could be a view in the system, for a table that does not exist, feel somehow wrong, but I agree we should fix that.

Comment #6

andrewbelcher CreditAttribution: andrewbelcher commented 16 January 2013 at 22:45

Our example was a module that had been disabled. But there were still views in the database built on an entity created by the disabled module...

It seems odd to be tracking $fully_loaded but not always respecting it...

Comment #7

Pedro Lozano CreditAttribution: Pedro Lozano commented 17 January 2013 at 08:05

In my case, it was some old broken views that were using fields that no longer existed. For each broken field, two views data cache rebuilds were performed.