Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

Issue tags: +Needs backport to D7

Won't it need a backport to D7?

Brolag’s picture

Status: Active » Needs review
FileSize
582 bytes

Could someone please review my patch? Thanks! :)

NOTE: Patch made at Drupal Camp Central America 2012.

andypost’s picture

Status: Needs review » Needs work

@Brolag great! now we need a test to make sure that it works properly
Suppose this code should be modified to assert a wrong (none-numberic) value

nick_schuch’s picture

Status: Needs work » Needs review
FileSize
779 bytes

Tried to kick off some tests but looks like core has moved on since this last patch. So here is the new one :)

valthebald’s picture

Great! Is it possible to create 2 patches: one with only modified test (this patch is supposed to fail, and that's ok), and the second one, which contains validation and test modification?

valthebald’s picture

Status: Needs review » Needs work

sorry, forgot to change status

nick_schuch’s picture

Assigned: Unassigned » nick_schuch

Working on tests.

nick_schuch’s picture

Status: Needs work » Closed (duplicate)

After writing tests and pulling down the lastest 8.x I discovered that element_validate_positive_integer has been taken away in place of a number field with '#min' set to 1.