It is follow-up from #1300920-72: The [node:summary] token does not output anything for body fields without a manual summary
Text widget already converted into plugin so it's a Novice task
Comment | File | Size | Author |
---|---|---|---|
#4 | added_elemente_validate_integer_positive__for__trim_lenght-1808942-4.patch | 779 bytes | nick_schuch |
#2 | added_elemente_validate_integer_positive__for__trim_lenght-1808942-2.patch | 582 bytes | Brolag |
Comments
Comment #1
DamienMcKennaWon't it need a backport to D7?
Comment #2
Brolag CreditAttribution: Brolag commentedCould someone please review my patch? Thanks! :)
NOTE: Patch made at Drupal Camp Central America 2012.
Comment #3
andypost@Brolag great! now we need a test to make sure that it works properly
Suppose this code should be modified to assert a wrong (none-numberic) value
Comment #4
nick_schuch CreditAttribution: nick_schuch commentedTried to kick off some tests but looks like core has moved on since this last patch. So here is the new one :)
Comment #5
valthebaldGreat! Is it possible to create 2 patches: one with only modified test (this patch is supposed to fail, and that's ok), and the second one, which contains validation and test modification?
Comment #6
valthebaldsorry, forgot to change status
Comment #7
nick_schuch CreditAttribution: nick_schuch commentedWorking on tests.
Comment #8
nick_schuch CreditAttribution: nick_schuch commentedAfter writing tests and pulling down the lastest 8.x I discovered that element_validate_positive_integer has been taken away in place of a number field with '#min' set to 1.