Problem/Motivation

WebTestBase::drupalLogin() uses $user as the user account to log in within the child environment. Usually, $user is reserved for the currently logged in user global.

Proposed resolution

Rename $user to $account within WebTestBase::drupalLogin().

CommentFileSizeAuthor
#4 1898314-D7-reanme.patch1.37 KBdroplet
#1 1898314.patch1.56 KBdroplet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Active » Needs review
FileSize
1898314.patch1.56 KB
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Reviewed & tested by the community

RTBC if it comes back green.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks. This actually caused a bunch of confusion in a recent review, so glad to see this fixed.

Committed and pushed to 8.x. Back to 7.x for backport.

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Patch (to be ported) » Needs review
FileSize
1898314-D7-reanme.patch1.37 KB
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Reviewed & tested by the community

Let's do it! :-)

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/94739f0

Automatically closed -- issue fixed for 2 weeks with no activity.