Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Drupal 6 used hook_perm(). In D7 it was changed to hook_permission().
Attached patch fixes it.
Comment | File | Size | Author |
---|---|---|---|
twitter_post-hook_perm.patch | 530 bytes | John Franklin | |
Comments
Comment #1
13rac1 CreditAttribution: 13rac1 commentedGood catch! Patch doesn't apply to 6.x-5.x-dev. Please clone the repo and make a patch directly from it.
Comment #2
John Franklin CreditAttribution: John Franklin commentedAre you serious?
Comment #3
13rac1 CreditAttribution: 13rac1 commentedI am not the maintainer of this module. I am simply reviewing patches. I know this is an EXTREMELY simple patch, but it doesn't apply correctly. I can easily fix this patch, but per Drupal rules, I cannot RTBC it.
This module has huge number of open issues, far more than the single unpaid regular maintainer (juampy) can review alone. So, please make this simpler/easier for the maintainer and supply patches that correctly apply.
TL;DR: Yes.
Comment #4
juampynr CreditAttribution: juampynr commentedThanks @eosrei ;D
Comment #5
juampynr CreditAttribution: juampynr commentedFixed. Thanks.
Comment #6
Drave Robber CreditAttribution: Drave Robber commented@juampy: instead of fixing 6.x-5.x, you broke 7.x-5.x.
It needs to be
twitter_post_perm()
in http://drupalcode.org/project/twitter.git/blob/refs/heads/6.x-5.x:/twitt... (6.x) andtwitter_post_permission()
in http://drupalcode.org/project/twitter.git/blob/refs/heads/7.x-5.x:/twitt... (7.x) - now it's all the way around.Comment #7
juampynr CreditAttribution: juampynr commentedLOL! Reverted on 7.x-5.x and fixed on 6.x-5.x.
Thanks