Remove custom error reporting for SimplePie. [#1485870]

in feeds.module it turns off E_DEPRECATED errors, with this comment

// We can safely use E_DEPRECATED since Drupal 7 requires PHP 5.3+

er, no it doesn't - from http://drupal.org/requirements

Drupal 7: 5.2.5 or higher (5.3 recommended)

Comment	File	Size	Author
#5	feeds-deprecated-1485870-5.patch	2.02 KB	twistor
#5
#2	feeds-deprecated-1485870-2.patch	1.37 KB	brad.bulger
#2
#1	feeds-deprecated-1485870-1.patch	1.37 KB	brad.bulger
#1
	feeds.php53.patch	754 bytes	brad.bulger

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

brad.bulger CreditAttribution: brad.bulger commented 30 January 2013 at 02:30

File	Size
feeds-deprecated-1485870-1.patch	1.37 KB

rebuilt patch against current version. the constant is referenced in two places, both related to SimplePie, so maybe there's a central place to define it if undefined, rather than testing for it.

Comment #2

brad.bulger CreditAttribution: brad.bulger commented 30 January 2013 at 02:37

File	Size
feeds-deprecated-1485870-2.patch	1.37 KB

sorry, whitespace error

Comment #3

Simon Georges CreditAttribution: Simon Georges commented 31 January 2013 at 10:34

Status:

Active

» Needs review

Changing status, as there is a patch.

Comment #4

twistor CreditAttribution: twistor commented 30 January 2014 at 03:58

Title:	check for existence of E_DEPRECATED before using it	» Remove custom error reporting for SimplePie.
Assigned:	Unassigned	» twistor
Category:	Bug report	» Task
Issue summary:	View changes
Status:	Needs review	» Needs work