Currently Panels uses isset() for determining whether a content type should be at the top level.

Consequently setting 'top level' to FALSE makes the content type appear at top level. It's illogical and goes against code and examples in Fieldable Panel Panes.

Instead of fixing this in Fieldable Panel Panes how about using empty() instead?

The following patch implements this change.

CommentFileSizeAuthor
#1 panels-top-level-empty-1836428-1.patch1.08 KBkasperg
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kasperg’s picture

kasperg CreditAttribution: kasperg commented
FileSize
panels-top-level-empty-1836428-1.patch1.08 KB

And here's the patch.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Needs review » Reviewed & tested by the community

I agree with this (though it's easy tow ork around by setting the value to NULL instead of FALSE).

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.