Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The converting process has been started.
Comment | File | Size | Author |
---|---|---|---|
#4 | 18435600-theme-menu-local-task-4.patch | 2.28 KB | killerpoke |
#4 | interdiff.txt | 143 bytes | killerpoke |
#2 | d8tts-theme-menu-local-task-18435600-2.patch | 2.28 KB | steveoliver |
#1 | theme_menu_local_task-1843560-1.patch | 1.29 KB | victor-shelepen |
Comments
Comment #1
victor-shelepen CreditAttribution: victor-shelepen commentedIt has been converted.
Comment #2
steveoliver CreditAttribution: steveoliver commentedWith preprocess, I'm thinking something more like this. However, it seems I couldn't find a 'local task' this affects - the primary nav and the tabs for a node, for example, don't seem to be affected by this. Can anyone confirm this patch works for Stark?
Comment #3
killerpoke CreditAttribution: killerpoke commentedComment #4
killerpoke CreditAttribution: killerpoke commentedTested with Stark, works for me except one notice:
I'v fixed this according to the annotations in Drupal\Core\Template\Attribute.
Comment #5
killerpoke CreditAttribution: killerpoke commentedComment #6
killerpoke CreditAttribution: killerpoke commentedAdd tag
Comment #7
mh86 CreditAttribution: mh86 commentedTested killerpoke's patch. PHP notice is gone now and rest looks good.
One small notice: inactive menu tasks have an empty class attribute now, but that's actually a different topic.
Comment #8
steveoliver CreditAttribution: steveoliver commentedUpdating title, tags; assigning myself.
Comment #9
steveoliver CreditAttribution: steveoliver commentedUpdating status.
Comment #10
steveoliver CreditAttribution: steveoliver commentedClosing this (instead of moving it to core queue) in favor of aggregated 'menu.inc' core issue #1898478: menu.inc - Convert theme_ functions to Twig. Git attributions to all participants will happen there.