If user without permission accesses node/%/group: Undefined index: map in og_context_handler_node() [#1901976]

If a user without access permissions tries to acces a URL like 'node/7/group' the following error occurs:
Undefined index: map in og_context_handler_node() on line 426 from og_context.module

Patch follows.

Comment	File	Size	Author
#3	og_context-removed-notice-2.patch	818 bytes	Blackice2999
#3
#1	og_context-removed-notice.patch	1.33 KB	Blackice2999
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Blackice2999 CreditAttribution: Blackice2999 commented 29 January 2013 at 14:17

Status:

Active

» Needs review

File	Size
og_context-removed-notice.patch	1.33 KB

Hi,

fixed missing existence check for map on menu item. (map only exist if a user has access to an item)

thanks
Dennis

Comment #2

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 29 January 2013 at 18:46

Status:

Needs review

» Needs work

Thanks.

+++ b/og_context/og_context.moduleundefined
@@ -422,13 +422,17 @@ function og_context_handler_node($node = NULL) {
+  // only proceed if map is exists (user has access)
+  if(isset($item['map']['1'])) {

I actually prefer to return early, e.g.: