Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I've installed the following panopoly modules individually in an install profile:
dependencies[] = panopoly_core
dependencies[] = panopoly_images
dependencies[] = panopoly_magic
dependencies[] = panopoly_theme
dependencies[] = panopoly_admin
dependencies[] = panopoly_widgets
When adding an image or map or video using the relevant widgets, when the modal window shows up, the content keeps refreshing, making it unusable, and eventually gives an ajax error.
I'm not sure if this is due to a patch in ctools or what could be causing it. Any ideas? While I know in general, I'd want the entire profile, I'm trying to figure out how some of these items have been put together.
Comment | File | Size | Author |
---|---|---|---|
#11 | panopoly_magic-ctools-autosubmit-filter-list-1795978-11.patch | 348 bytes | saltednut |
#8 | panopoly_widgets-better-formats-1795978-8.patch | 3.12 KB | saltednut |
#4 | Screen Shot 2013-02-02 at 4.26.54 PM.png | 104.05 KB | saltednut |
#4 | panopoly_magic-autosubmit-widgets-fpp-1795978-4.patch | 565 bytes | saltednut |
Comments
Comment #1
populist CreditAttribution: populist commentedI would check out this page for information on using Panopoly as a base installation - http://drupal.org/node/1651128
Comment #2
populist CreditAttribution: populist commentedI am going to postpone this because my guess is that there is a wierd interaction with the versions of the modules you are running and the versions/patches Panopoly is expecting. Give those directions a whirl and that should work for you.
Comment #3
populist CreditAttribution: populist commentedI did some more testing and could not replicate. Would recommend updating to Panopoly module set.
Comment #4
saltednutIts fairly easy to reproduce using latest Drupal and just including the modules. In fact, I'm having a hard time not producing this problem unless I use a fresh install of Panopoly. From what I can tell, this is an issue coming from Panopoly Magic where multiple elements are being assigned the autosubmit class. This seems to be causing a lot of the fieldable_panels_panes widgets to go into an autosubmit loop.
I found dawehner's blog about using ctools_add_js to do an autosubmit and he's implementing it slightly differently.
The attached patch fixes this autosubmit loop for me. Unsure if its exactly the correct solution though. As I am, at best, a pixelated black mage... certainly not a fully enlightened chaos wizard. Please advise. :)
Comment #5
saltednutAfter further testing, it seems this didn't fully fix the issue. Removing the
ctools_add_js('auto-submit');
prevents the loop from happening, but it also makes it so that file fields and their ahah attributes do not autosubmit the form.Comment #6
saltednutIt looks like you need the config that comes from panopoly_wysiwyg. See: #1822222: Problem with Displaying Filter Tips and Auto Submit
This fixed the redirect loop.
It woud be good to decouple the WYSIWYG from panopoly_magic but right now this appears to be required.
Comment #7
saltednutComment #8
saltednutThe redirect is caused by a lack of some type of WYSIWYG - in the case of an image, map or any FPP introduced by panopoly_widgets that contains a textarea, one enters a World of Pain™ (infinite loop) without some type of WYSIWYG to block this autosubmit from happening. I haven't determined where in the JS this is happening, but it basically means panopoly_widgets is dependent of panopoly_wysiwyg.
On top of that, if one is to introduce a different WYSIWYG, such as CKEditor, this makes the FPP look crazy with scrolling modal window sadness. In general, I love having the panopoly_wysiwyg tinymce for these FPP, but its not robust enough for editing node content. Rather than dealing with this ugliness...
I'm proposing a two-fold solution:
#1 Declare that panopoly_widgets are dependent to panopoly_wysiwyg
#2 Use http://drupal.org/project/better_formats to force the panopoly_wysiwyg filters onto these textareas.
Comment #9
saltednutComment #10
populist CreditAttribution: populist commentedThanks much for the deep dive here and I think Better Formats could be a good solution here. Postponing till after RC4, but infinite loads are certainly bad.
Comment #11
saltednutSimple fix after months...
I'll try to be short here: its the "Text Format" select input that causes the looping.
If you're using WYSIWYG module, the text format simply goes to default. If you change the text format, you get a live preview. Cool.
If you're not using WYSIWYG module, aka using CKEditor module, you need to add this line to panopoly_magic.js
CKEditor Module does some craziness when processing its editor. Part of this includes monkeying with the "Text Format" select area. This monkey business is our culprit for the infinite looping.
This patch will prevent the ctools autosubmit from firing when a user changes a text format. Should be the first step towards switching to adding Edit module and CKEditor to Panopoly. :)
Comment #12
saltednutComment #13
populist CreditAttribution: populist commentedThis is quite nice and thanks for tracking this down! Reviewed + Committed.