Hi,

I'm trying to downgrade from beta3 to beta1 - but even after disableing and uninstalling all LDAP modules - it doesn't remove ldap_servers table.

I then tried to drop that table manually, and then install beta1 - but it doesn't create the table - it just complains that it isn't there :(

Comments

johnbarclay’s picture

Title: uninstall doesn't work for ldap_servers - reinstall doesn't create ldap_servers table » LDAP Servers: uninstall doesn't work for ldap_servers - reinstall doesn't create ldap_servers table

What does the system database table say in the ldap_server record in the "schema_version" column?

If you manually want to reinstall, be sure to remove all the ldap_* records in the system table.

johnbarclay’s picture

Version: 7.x-2.0-beta1 » 7.x-2.x-dev
Assigned: Unassigned » johnbarclay
Priority: Normal » Major

I'm not sure about the downgrade path, but the uninstall needs to remove everything.

johnbarclay’s picture

Title: LDAP Servers: uninstall doesn't work for ldap_servers - reinstall doesn't create ldap_servers table » LDAP *: Uninstall Issues
Priority: Major » Normal

Currently the uninstall code should remove all ldap_* tables, all ldap_* variables, and all ldap fields. I just committd a patch to get rid of the last ldap_user variables. The only data it should leave in $user->data[] data which will need a cron/batch process to remove. I'm leaving this issue open as a catch all for uninstall issues until they are all worked through. My experience has been that uninstall code is unreliable to test with simpletest coverage.

CodyS’s picture

I am using 7.x-2.0-beta3 and I disabled all LDAP modules and uninstalled them.

But the LDAP modules still appear in my module list disabled and no longer show up in my Uninstall list.

johnbarclay’s picture

This thread is for 7.x-2.x-dev

johnbarclay’s picture

Priority: Normal » Major
johnbarclay’s picture

Status: Active » Needs review

@#4, I can't reproduce this. Is there a dependency or were the fields in ldap_user not removed?

The most recent commit covers removal of $user->data['ldap_authorizations'] data on uninstall. This is the last of the code for uninstalling ldap_* completely. Please test.

All tables, variables, and $user->data related to ldap should be removed on uninstall.

johnbarclay’s picture

Status: Needs review » Closed (fixed)