Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There is an error in the code that sets the time for extracting the thumbnails. I think it is a custom modification of the PHPVideoToolkit made for the Drupal version, because it is not present in the original code available in the project repository.
In lines 1855-1856 it reads:
<?php
$this->addCommand('-ss', $this->formatTimecode($seconds - 5, $timecode_format, '%hh:%mm:%ss:%ms', $frames_per_second), TRUE);
$this->addCommand('-ss', $this->formatTimecode(5, $timecode_format, '%hh:%mm:%ss:%ms', $frames_per_second), FALSE);
?>
The timecode format is wrong. Milliseconds must use a dot "." as separator. The correct code is:
<?php
$this->addCommand('-ss', $this->formatTimecode($seconds - 5, $timecode_format, '%hh:%mm:%ss.%ms', $frames_per_second), TRUE);
$this->addCommand('-ss', $this->formatTimecode(5, $timecode_format, '%hh:%mm:%ss.%ms', $frames_per_second), FALSE);
?>
You owe me a beer for the time wasted debugging this ;)
Comment | File | Size | Author |
---|---|---|---|
#1 | video-invalid_timecode-1907504-1.patch | 1.09 KB | JvE |
Comments
Comment #1
JvE CreditAttribution: JvE commentedNasty bug. Wasted some of my time too.
The ffmpeg error message (for reference): "Invalid duration specification for ss"
Comment #2
Jorrit CreditAttribution: Jorrit commentedThanks a lot for finding this! Next time you're in The Netherlands, I'll buy you a beer :)
Comment #3
marcusn CreditAttribution: marcusn commentedNext time you are in Finland I will buy you two beers.