Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
It seems that ER's autocomplete tags widget wasn't tested properly so currently you can't enter more than one entity in the autocomplete field.
Comment | File | Size | Author |
---|---|---|---|
#9 | 1914180-unbreak_autocomplete-9.patch | 7.76 KB | amateescu |
#7 | 1914180-unbreak_autocomplete-7.patch | 12.7 KB | amateescu |
#7 | interdiff.txt | 2.59 KB | amateescu |
#5 | 1914180-unbreak_autocomplete-5.patch | 12.51 KB | amateescu |
#5 | interdiff.txt | 2.66 KB | amateescu |
Comments
Comment #1
amateescu CreditAttribution: amateescu commentedThis should do the job, adding proper tests and whatnot :)
P.S. The change of
elementValidate()
method tovalidateElement()
was done in order to be consistent with the patch from #1751234: Convert option widgets to Plugin system.Comment #2
dawehnerwhat about using drupal_implode_tags ?
Comment #3
amateescu CreditAttribution: amateescu commentedNice find! Attaching a test-only patch as well to see the failure easier.
Comment #4
dawehnerIn general it wills wrong to talk about tags, but yeah this should/could be fixed in the controller issue.
Sure all these changes feels out of scope here, but I discussed with @amateescu and I think it's okay to change this, especially because this files will probably not touched by other patches.
Any reason to not use drupalGetAjax here?
Comment #5
amateescu CreditAttribution: amateescu commentedFixed 1) and 3) from above.
Comment #6
dawehnerLet's fix the variables in the controller issue.
This
Space after $second_term->name missing :)
Comment #7
amateescu CreditAttribution: amateescu commentedI already changed too much in here.. what's three lines more :)
Fixed both issues.
Comment #8
dawehner-1
Comment #9
amateescu CreditAttribution: amateescu commentedYep, you're right, let's just fix the bug, there's plenty of time for cleanups.
Comment #10
dawehnerYeah once you have a big patch in, things move slower then before.
Thanks for keeping the patch as small as possible.
Comment #11
catchCommitted/pushed to 8.x, thanks!