D7's pattern is to provide a drupal_alter(), so implementing modules can alter the definitions.
Patch will follow.

CommentFileSizeAuthor
#3 1916988-conditional-fields-alter-3.patch666 bytesNofarG
#1 1916988-conditional-fields-alter-1.patch1.85 KBamitaibu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
Status: Active » Needs review
FileSize
1916988-conditional-fields-alter-1.patch1.85 KB

Attached.

NofarG’s picture

NofarG CreditAttribution: NofarG commented
Status: Needs review » Closed (works as designed)

The alter hook is already provided by features. See features_get_default()

NofarG’s picture

NofarG CreditAttribution: NofarG commented
Status: Closed (works as designed) » Needs review
FileSize
1916988-conditional-fields-alter-3.patch666 bytes

New patch attached.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin commented

Seems to be fine in D6 too. Same code.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Reviewed & tested by the community

This is the correct approach.

hefox’s picture

hefox CreditAttribution: hefox commented

ditto, patch looks good

peterpoe’s picture

peterpoe CreditAttribution: peterpoe commented
Title: provide an alter hook for conditional_fields_default_fields() » Use features_get_default() in conditional_fields_features_rebuild() instead of custom hook
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.