Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
In FeedsSource::import() there is an exception block that ends
catch (Exception $e) {
// Do nothing.
}
in fact, this exception is being stored and re-thrown after we've had a chance to do some clean up (a bit like a finally block that doesn't require PHP 5.5). The comment (and any similar comments) should be corrected to reflect this.
Comment | File | Size | Author |
---|---|---|---|
#1 | feeds-1852048-document-finally-emulation-1.patch | 838 bytes | ianthomas_uk |
Comments
Comment #1
ianthomas_ukHere is a patch for the two examples I was able to find.
Replaces the "Do nothing" comment with one saying "$e is stored and re-thrown once we've had a chance to log our progress"
Comment #2
ianthomas_ukAny chance of getting this committed? It's just a comment change, and it would be a shame if it bitrotted or confused anyone else.
Comment #3
twistor CreditAttribution: twistor commentedHey, only took 2 years.
http://drupalcode.org/project/feeds.git/commit/8fb014a