Create a transaction during the customer checkout process [#1904244]

With this patch, you can be sure that the checkout create a transaction. Offline project (with internet access), can now user Merchant Query Interface to check the status of the transaction.
If the payment gateway don't send a success message, you can't go to the next order pane.

Please review.
(patch in next message)

Comment	File	Size	Author
#3	commerce_moneybookers-create_transaction_during_customers_checkout_process-1904244-3.patch	9.87 KB	JulienD
#3
#2	commerce_moneybookers-Make_sure_the_checkout_create_a_transaction-1904244-2.patch	8.34 KB	bennetteson
#2
#1	commerce_moneybookers-Make_sure_the_checkout_create_a_transaction-1904244-1.patch	8.21 KB	bennetteson
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

bennetteson CreditAttribution: bennetteson commented 31 January 2013 at 13:01

File	Size
commerce_moneybookers-Make_sure_the_checkout_create_a_transaction-1904244-1.patch	8.21 KB

First draft.

Comment #2

bennetteson CreditAttribution: bennetteson commented 4 February 2013 at 13:14

File	Size
commerce_moneybookers-Make_sure_the_checkout_create_a_transaction-1904244-2.patch	8.34 KB

Second draft.
The query request don't return the failure raison.

Comment #3

JulienD CreditAttribution: JulienD commented 21 February 2013 at 10:07

Title:

Make sure the checkout create a transaction.

» Create a transaction during the customer checkout process

File	Size
commerce_moneybookers-create_transaction_during_customers_checkout_process-1904244-3.patch	9.87 KB

Hi,

Currently, a transaction is only created during the reception of a payment notification from moneybookers. This patch add the possibility to create transaction after the customer succeeds the payment of his order.

I've tested Bennetteson's patch and it's working fine except the fact how a transaction is loaded from the database. Currently the first transaction of an order will always be loaded instead of the last one. I've rerolled the patch to correct this little stuff.

I've renamed the title for a better comprehension

Comment #4

jsacksick CreditAttribution: jsacksick commented 3 April 2013 at 12:12

Status:

Needs review

» Needs work

+++ b/commerce_moneybookers_quickcheckout/commerce_moneybookers_quickcheckout.module
@@ -169,45 +183,127 @@ function commerce_moneybookers_quickcheckout_settings_form($settings = NULL) {
+  if (arg(4) != $order->data['payment_redirect_key']) {

Are you really sure we need that ?

Comment #5

jsacksick CreditAttribution: jsacksick commented 3 April 2013 at 13:11

This patch is not correct, because the EFQ checks if there's at least one transaction and take the last one, but what if all of them have failed ? Then it won't enter the mqi and we're not going to create the transaction. This has to be fixed.