Views integration: address access filters [#1900150]

This is a subissue of #1391216: Views integration for the 6.x-2.x and 7.x-1.x version

Problem/Motivation

When displaying a View of addresses, it would be nice to be able to filter out addresses the user is not supposed to see.

Proposed resolution

There should be three Views filters implemented to filter on address access:

A filter for if the address may be viewed.
A filter for if the address may be edited.
A filter for if the address may be deleted.

These three filters should be connected with the permissions class (UcAddressesPermissions).

Because checking address access would require a full address object, it should leave out support for pager, as checking access for all addresses could become a real performance hit.

Remaining tasks

Implement the three access filters.

User interface changes

None directly, but site builders will get an option in Views to filter out addresses the user should not have access to.

API changes

None.

A patch will follow.

Comment	File	Size	Author
#9	uc_addresses7-views-access-filters-1900150-9.patch	4.63 KB	MegaChriz
#9
#7	uc_addresses6-views-access-filters-1900150-7.patch	18.46 KB	MegaChriz
#7
#5	uc_addresses-views-access-filters-1900150-5.patch	16.94 KB	MegaChriz
#5
#4	uc_addresses-views-access-filters-1900150-4.patch	16.11 KB	MegaChriz
#4
#2	uc_addresses-views-access-filters-1900150-2.patch	16.02 KB	MegaChriz
#2
#1	uc_addresses-views-access-filters-1900150-1.patch	5 KB	MegaChriz
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

MegaChriz CreditAttribution: MegaChriz commented 27 January 2013 at 11:09

Status:	Active	» Needs review
Issue tags:		+Needs tests

File	Size
uc_addresses-views-access-filters-1900150-1.patch	5 KB

This is my first attempt for implementing the access filters. As mentioned in the issue summary, it does not work well with pager.

This could use some tests.

File	Size
uc_addresses-views-access-filters-1900150-2.patch	16.02 KB

Comment #3

2 February 2013 at 19:42

Status:

Needs review

» Needs work

The last submitted patch, uc_addresses-views-access-filters-1900150-2.patch, failed testing.

Comment #4

MegaChriz CreditAttribution: MegaChriz commented 2 February 2013 at 19:48

Status:

Needs work

» Needs review

File	Size
uc_addresses-views-access-filters-1900150-4.patch	16.11 KB

Now is ensured that the base test class is included.

Comment #5

MegaChriz CreditAttribution: MegaChriz commented 9 February 2013 at 08:18

File	Size
uc_addresses-views-access-filters-1900150-5.patch	16.94 KB

This adds some extra documentation. Other then that, I think it's ready. Let's see if it still passes tests.

Comment #6

MegaChriz CreditAttribution: MegaChriz commented 14 February 2013 at 13:15

Version:	7.x-1.x-dev	» 6.x-2.x-dev
Status:	Needs review	» Patch (to be ported)

Committed #5 with some small modifications in the code comments: there appeared to be a reference to the Views PHP module, which I had used as an example.

Needs backport to 6.x-2.x. I expects this could become quite a challenge, as some things work differently in Views 2.

Comment #7

MegaChriz CreditAttribution: MegaChriz commented 21 February 2013 at 20:03

Status:	Patch (to be ported)	» Needs review
Issue tags:	-Needs tests

File	Size
uc_addresses6-views-access-filters-1900150-7.patch	18.46 KB

It took me some hours to figure out, but here's a patch for the 6.x-2.x version. Again, I took Views PHP as an example, but then the 6.x-1.x version of that module in this case. I've also taken a bit other approach to find out how the address ID field is called in the results. For the 7.x-1.x version (see #5) this came more to guessing. The filter for the 6.x-2.x just adds two fields to query and uses that in the result rows to load the complete address and check access.

So, I probably need to make a few modifications to the 7.x-1.x implementation after I'm done with the 6.x-2.x implementation. Not only for consistency, but also because I think the 6.x-2.x implementation is more stable.