Administration menu overlaps editors in fullscreen mode [#1898210]

See attached screens.

Comment	File	Size	Author
#1	wysiwyg-fullscreen-admin-menu.1898210.1.patch	3.41 KB	TwoD
	After maximising.png	17.99 KB	dddbbb
	Before maximising.png	48.24 KB	dddbbb

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

TwoD

Swedish

Sweden

CreditAttribution: TwoD commented 25 February 2013 at 04:46

Title:	CKEditor 4 'maximise' leads to edior toolbar displayed under admin_menu toolbar	» Administration menu overlaps editors in fullscreen mode
Version:	7.x-2.2	» 7.x-2.x-dev
Component:	Editor - CKEditor	» User interface
Status:	Active	» Needs review

File	Size
wysiwyg-fullscreen-admin-menu.1898210.1.patch	3.41 KB

This appears to happen only when the Overlay is used. We've already got the logic in place to hide the standard Toolbar for editors which supports fullscreen modes, so this patch simply adds #admin-menu to the list of elements to show/hide.

Comment #2

dddbbb CreditAttribution: dddbbb commented 25 February 2013 at 14:55

Status:

Needs review

» Reviewed & tested by the community

That patch seems to fix the issue for me. Many thanks.

Comment #3

sun

German

Karlsruhe

CreditAttribution: sun commented 25 February 2013 at 15:25

Looks good.

As a possible follow-up improvement (in a separate issue), we could investigate to provide central API helper methods for this, in order to decrease the amount of duplicated code.

Comment #4

TwoD

Swedish

Sweden

CreditAttribution: TwoD commented 25 February 2013 at 16:25

Status:

Reviewed & tested by the community

» Fixed

Thanks for the quick review, sorry it took me a month to patch this.

I've committed this to all major branches and the -dev snapshots will be updated within 12 hours and this will be part of the next official releases..

EDIT: Yes, a central utility function sounds good.
Follow-up in #1927000: Add utility functions for fullscreen mode management.