The comment in system_init says to call db_set_ignore_slave() but the function is called db_ignore_slave(). Also, the comment block exceeds column 80 on a few lines so we might as will make it standards compliant at the same time.

CommentFileSizeAuthor
#1 Incorrect_function_name-1926758-1.patch2.18 KBbalsama
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

balsama’s picture

balsama
he/him
Primary language English
Location boston
CreditAttribution: balsama commented
Status: Needs work » Needs review
FileSize
Incorrect_function_name-1926758-1.patch2.18 KB

Patch attached.

* Changes function name to db_ignore_slave()
* Edit comment block so that no lines exceed 80 characters.

mitron’s picture

mitron CreditAttribution: mitron commented
Status: Needs review » Reviewed & tested by the community

Looks great.

mitron’s picture

mitron CreditAttribution: mitron commented
Assigned: mitron » Unassigned
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Component: system.module » documentation
Assigned: Unassigned » jhodgdon

Switching components, assigning to Jennifer. Thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

I'll wait until #1793074: Convert .info files to YAML is committed (avoid commit conflicts issue that touches the same file) to commit this. They might not conflict but I just like to avoid touching the same file when an issue is tagged "avoid commit conflicts".

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Fixed

I committed this to 8.x, and as the code/docs/problem were the same in 7.x, committed to 7.x too. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.