Extending gmap module *.tests. Catching test gaps.

Test coverage partially done for views plugins ( #1934122: Gmap Views tests. Needs extending and fixing follow-ups ) and only for forms with "Submit" default values via Views UI interface
But there are huge part of code without coverage and we should GTD

Good to see here code snippets from developers from gmap repository that possibly have to be covered first of all

extending test files

/tests/gmap.test
/gmap_test/tests/gmap_test.test
/gmap_test_extended/tests/gmap_test_extended.test

Follow-Ups

#1252310-1: Undefined index: location_settings
#1934122: Gmap Views tests. Needs extending and fixing follow-ups

ToDo

#1926360: Compatibility lost with Geofield (in gmap_plugin_style_gmap.inc).
#1929544: Fix for Relative Path from Root to gmap_markers.js to make Markers show
#1890460: Undefined index: style_plugin in gmap_views_ajax_data_alter() of gmap.module
#1928812: Notice: Undefined index: node in gmap_taxonomy_get_instances() (line 269 gmap_taxonomy.module
#1913268: gmap_plugin_style_gmap.inc (line 165) : Trying to get property of non-object in gmap_plugin_style_gmap->render().
#1928834: Clean info files of unneeded files declarations. Change module description.
#1912168: Warning "Undefined variable: bubbletext_field_obj in gmap_plugin_style_gmap->render()"
#923630: Markers not showing up on Gmaps no matter what: How to debug
#1907478: Gmap gmap style views plugin using non-existing property geofield

and others with Needs tests tag

Related issues

#1931088: [META] Fixing tests
#1890460: Undefined index: style_plugin in gmap_views_ajax_data_alter() of gmap.module

Examples

#1870764-81: Add an ajax command which makes it easy to use the dialog API in complex cases Good javascript testing example

Comment	File	Size	Author
#13	1926846-13.patch	850 bytes	podarok
#13
#10	1926846-10.patch	4.1 KB	podarok
#10
#6	tests1.patch	5.78 KB	podarok
#6
#5	tests1.patch	5.65 KB	podarok
#5
	testfix.patch	513 bytes	podarok

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 25 February 2013 at 14:18

Version:

7.x-2.x-dev

» 7.x-2.4-beta2

proper version

Log in or register to post comments

Comment #2

25 February 2013 at 14:35

Status:

Needs review

» Needs work

The last submitted patch, testfix.patch, failed testing.

Log in or register to post comments

Comment #3

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 25 February 2013 at 14:38

commited pushed to 7.x-2.x and 7.x-1.x branches

Log in or register to post comments

Comment #4

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 25 February 2013 at 14:38

Status:

Needs work

» Closed (fixed)

tag

Log in or register to post comments

Comment #5

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 25 February 2013 at 18:48

Title:	Fixing gmap.test	» Extending gmap.test
Version:	7.x-2.4-beta2	» 7.x-2.x-dev
Status:	Closed (fixed)	» Needs review

File	Size
tests1.patch	5.65 KB

addition to tests

Log in or register to post comments

Comment #6

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 25 February 2013 at 18:53

File	Size
tests1.patch	5.78 KB

yet one

Log in or register to post comments

Comment #7

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 25 February 2013 at 19:01

Version:

7.x-2.x-dev

» 7.x-1.x-dev

tag

Log in or register to post comments

Comment #8

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 25 February 2013 at 19:01

#6: tests1.patch queued for re-testing.

Log in or register to post comments

Comment #9

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 25 February 2013 at 19:09

Version:	7.x-1.x-dev	» 7.x-2.x-dev
Status:	Needs review	» Fixed

pushed to 1.x 2.x

Log in or register to post comments

Comment #10

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 26 February 2013 at 01:52

Status:

Fixed

» Needs review

File	Size
1926846-10.patch	4.1 KB

provide tests for location_gmap_find_address module

#1252310-1: Undefined index: location_settings follow-up for exeption fix

Log in or register to post comments

Comment #11

26 February 2013 at 01:33

Status:

Fixed

» Needs work

The last submitted patch, 1926846-10.patch, failed testing.

Log in or register to post comments

Comment #12

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 26 February 2013 at 01:35

Status:

Needs work

» Fixed

#10 commited / pushed to 7.x-2.x-dev

Log in or register to post comments

Comment #13

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 26 February 2013 at 02:54

File	Size
1926846-13.patch	850 bytes

temporary fix due to #1252310-1: Undefined index: location_settings

Log in or register to post comments

Comment #14

26 February 2013 at 10:13

Status:

Needs review

» Needs work

The last submitted patch, 1926846-13.patch, failed testing.

Log in or register to post comments

Comment #15

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 26 February 2013 at 10:15

#13 commited / pushed to 7.x-2.x-dev

Log in or register to post comments

Comment #16

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 26 February 2013 at 16:22

Status:

Needs work

» Postponed

postponed till #1252310-1: Undefined index: location_settings

Log in or register to post comments

Comment #17

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 28 February 2013 at 21:23

Category:	bug	» task
Priority:	Major	» Critical

this is critical task

Log in or register to post comments

Comment #17.0

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 28 February 2013 at 21:23

Issue summary:

Updated issue summary.

Log in or register to post comments

Comment #17.1

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 28 February 2013 at 21:25

Issue summary:

Updated issue summary.

Log in or register to post comments

Comment #17.2

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 1 March 2013 at 11:29

Issue summary:

Updated issue summary.

Log in or register to post comments

Comment #17.3

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 1 March 2013 at 18:57

Issue summary:

Updated issue summary.

Log in or register to post comments

Comment #17.4

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 1 March 2013 at 19:38

Issue summary:

Updated issue summary.

Log in or register to post comments

Comment #18

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 10 March 2013 at 10:59

Title:	Extending gmap.test	» Extending gmap module *.tests
Assigned:	podarok	» Unassigned
Status:	Postponed	» Active

Better title and this is now common task. Anyone can extend and fix it
We already have tests at paths

/tests/gmap.test
/gmap_test/tests/gmap_test.test
/gmap_test_extended/tests/gmap_test_extended.test

Log in or register to post comments

Comment #18.0

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 10 March 2013 at 10:59

Issue summary:

Updated issue summary.

Log in or register to post comments

Comment #18.1

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 10 March 2013 at 10:59

Issue summary:

Updated issue summary.

Log in or register to post comments

Comment #18.2

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 10 March 2013 at 11:00

Issue summary:

summary update

Log in or register to post comments

Comment #19

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 11 March 2013 at 23:49

Title:

Extending gmap module *.tests

» Extending gmap module *.tests. Catching test gaps.

Test coverage partially done for views plugins and only forms with "Submit" default values via Views UI interface
But there are huge part of code without coverage and we should GTD

Good to see here code snippets from developers from gmap repository that possibly have to be covered first of all

Log in or register to post comments

Comment #19.0

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 11 March 2013 at 23:49

Issue summary:

Updated issue summary.

Log in or register to post comments

Comment #19.1

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 11 March 2013 at 23:50

Issue summary:

Updated issue summary.

Log in or register to post comments

Comment #19.2

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 11 March 2013 at 23:51

Issue summary:

Updated issue summary.

Log in or register to post comments

Comment #19.3

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 14 March 2013 at 21:53

Issue summary:

Updated issue summary.

Log in or register to post comments

Comment #19.4

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 27 March 2013 at 14:52

Issue summary:

Updated issue summary.

Log in or register to post comments