the 'Blocked' checkbox under the "User status that can be referenced" field setting does not take.
That's most probably because the associated value is 0.

There was a long standing core issue about that, and I thought this was finally fixed. I can't seem to find it right now, though...

CommentFileSizeAuthor
#11 references_allow_referencing_blocked_users-1038102-11.patch1.06 KBMantasK
#7 references_allow_referencing_blocked_users-1038102-7.patch614 bytesdtarc
#2 user_reference_1038102.patch1.78 KBfgm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

Confirm this. as I remember there was 2-3 issues with '0' values of radios checkboxes but all been fixed in core...

suppose issue related to current implementation...

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Status: Active » Needs review
FileSize
user_reference_1038102.patch1.78 KB

Replaced the use of 0 and 1 by string values to avoid falling in this type of bug.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Status: Needs review » Needs work

As possibly faster solution was suggested by dereine, using a '-0' option instead of '0' and fixing up the value in submit. Then there is no need for the conversion loop in the suggested patch.

And, of course, we need a test to validate the changes.

yched’s picture

yched CreditAttribution: yched commented

Agreed, I'd favor a workaround strictly contained within FAPI processing, without changing the semantics of the stored values.

Also (minor) : if both checkboxes are checked, no need to add anything to the query.

rt_davies’s picture

rt_davies CreditAttribution: rt_davies commented

subscribe

bocaj’s picture

bocaj CreditAttribution: bocaj commented

Changing line 91 in user_reference.module from:

'#options' => array(1 => t('Active'), 0 => t('Blocked')),

to:

'#options' => array(1 => t('Active'), '-0' => t('Blocked')),

worked for me. Not sure that it's the best way to handle it, but now it functions like I expected!

dtarc’s picture

dtarc CreditAttribution: dtarc commented
Status: Needs work » Needs review
FileSize
references_allow_referencing_blocked_users-1038102-7.patch614 bytes

The suggestion in #6 worked for me, here's a patch.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

I think using '-0' should have (int) in 

- $query->condition('u.status', $field['settings']['referenceable_status']);
+ $query->condition('u.status', (int) $field['settings']['referenceable_status']);
alanburke’s picture

alanburke CreditAttribution: alanburke commented

I don't think this matters anymore - I don't seem to have the issue in any case

presleyd’s picture

presleyd CreditAttribution: presleyd commented

Problem still exists in 2.1 perhaps it was fixed in dev? Patch in 7 still works in 2.1 though.

MantasK’s picture

MantasK CreditAttribution: MantasK commented
Issue summary: View changes
FileSize
references_allow_referencing_blocked_users-1038102-11.patch1.06 KB

as it is not fixed, one more patch :)

Status: Needs review » Needs work

The last submitted patch, 11: references_allow_referencing_blocked_users-1038102-11.patch, failed testing.

fullerja’s picture

fullerja CreditAttribution: fullerja commented

Patch in #7 worked well for me