Looks like the documentation for the image_scale function is missing the word "be" in the explination of both the $width and $height paramaters.

http://api.drupal.org/api/drupal/core%21includes%21image.inc/function/im...

the scaling will based only should be the scaling will be based only

CommentFileSizeAuthor
#2 documentation-for-image_scale-1932354-2.patch989 bytestoastieAlex
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

toastieAlex’s picture

toastieAlex CreditAttribution: toastieAlex commented
Assigned: Unassigned » toastieAlex

Need to use the documentation from image_dimensions_scale() to address this issue. I'll have a patch in an hour.

toastieAlex’s picture

toastieAlex CreditAttribution: toastieAlex commented
Status: Active » Needs review
FileSize
documentation-for-image_scale-1932354-2.patch989 bytes

Will also need backporting to 7.x.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Assigned: toastieAlex » jhodgdon
Status: Needs review » Reviewed & tested by the community

Thanks! I'll get this committed shortly (quite likely the same patch will apply to 7.x as well; if not we'll need to make another one).

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed to 7.x and 8.x -- thanks again!

Automatically closed -- issue fixed for 2 weeks with no activity.