After installing drupal (latest head) I disabled the overlay module and I noticed that primary tabs stopped working!
My screen reader recognizes the title "Primary tabs" and the tabs as plain text, so I cannot use them at all.
I don't know if this is a bare accessibility issue or primary tabs are broken on Mac OS X (don't know for other OS) even for sighted users.
When the overlay module is enabled primary tabs work properly.
Comment | File | Size | Author |
---|---|---|---|
#8 | fix_primary_tabs.patch | 442 bytes | falcon03 |
Comments
Comment #1
falcon03 CreditAttribution: falcon03 commentedtagging
Comment #2
andrewmacpherson CreditAttribution: andrewmacpherson commentedI don't currently have access to a Mac, so wasn't able to test this on OS X.
I tested with the following set-ups, and didn't encounter a problem:
Primary tabs were announced as links within list items, and were operable (both with and without the overlay).
Anyone else able to confirm this on OS X?
Comment #3
danielnolde CreditAttribution: danielnolde commentedI can confirm #2 that primary- as well as sub-tabs are working as expected in graphical browsers Chrome 25, Safari 6.0.1 and Firefox 15.0.1 under Mac OS X 10.8.2 (tested on admin/content/comment logged in as admin).
Comment #4
danielnolde CreditAttribution: danielnolde commentedI can confirm #2 that primary- as well as sub-tabs are working as expected in graphical browsers Chrome 25, Safari 6.0.1 and Firefox 15.0.1 under Mac OS X 10.8.2 (tested on admin/content/comment logged in as admin).
Comment #5
mgiffordIs this possibly a VoiceOver issue? So far it doesn't seem like anyone has been able to reproduce this. That happens easily enough.
Comment #6
falcon03 CreditAttribution: falcon03 commented@everyone: primary tabs at admin/content work great for me now. But tabs at
/admin/config/people/accounts
and at
/admin/modules
do not.
I do not have a windows testing environment right now, unfortunately.
Comment #7
webchickSounds like we need a bit more information to reproduce this bug.
Comment #8
falcon03 CreditAttribution: falcon03 commented@webchick: I found what was causing the problem. In seven' page.html.twig (but not in other themes or in the core template), the variable to output primary tabs was wrapped in a div which the ARIA role "tab" was assigned to. Since the "tab" ARIA role shouldn't have been used this way, Voiceover was going crazy and wasn't intercepting the primary tabs correctly. I'm attaching a patch to fix the problem.
On a side note, though, can someone tell me why tabs in seven' page.html.twig are printed from a variable called "primary_local_tasks" while elsewhere they are printed from a variable called "tabs"? This seems not consistent to me...
Also, the default page.html.twig could need some cleanup, I think; essentially it could need just some new lines to make the code more readable at a quick glance (for sighted user) and tidier (for anyone). Maybe it's a different issue, though.
Comment #9
jessebeach CreditAttribution: jessebeach commentedLooks good. It's a simple fix.
Comment #10
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.