How can one add a class to the rendered table when a view is outputted as table?

In html-list format for example one can add a class to a wrapper OR/AND to the list. Is this possible to the table as well?

Thanks!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

eridolfi’s picture

I have done it before using views templates. Are you familiar with using views templates? If not, there is a link under "Advanced" that is titled, "Theme Information" or something like that. You can click that link and look for style output.

There are a number of different filename suggestions. You can get very specific with the naming. Once you have created the file in your theme's folder, simply click the style output link. Copy the code and then paste it into the empty file in your theme's folder.

If you have questions, please let me know.

bartvdputte’s picture

Thanks for your reply.

Eventually I did it this way, but in my opinion it makes no sense creating different "view templates" for each necessary view that has a table output, only to add a class to the table.

Besides that, it's not consistent with how view formatting works in other formats. As I said in my original post, in the html list format you can easily add classes in the UI. Why not in the table format?

adammalone’s picture

I'm also looking for this. Views has the ability to give a class to a row as well as give a class to an entire view, so why not allow classes to be given to tables?

Taking a look in theme/views-view-table.tpl.php, it looks like the functionality to add a class to a table is there, just not in the Views UI interface.
<table <?php if ($classes) { print 'class="'. $classes . '" '; } ?><?php print $attributes; ?>>

jhuon’s picture

Same problem here. Looking in the style output:
$classes: A class or classes to apply to the table, based on settings.
But I can't find this setting in Views UI neither.

danharper’s picture

I'm looking for this also.

moniuch’s picture

I second this request, I totally agree with #3 and while I'm sure everybody found a workaround to do that in template, I think it's leading us to a disease called tpl'itis.

agerson’s picture

Component: Miscellaneous » table style
Category: support » bug

Yes, this implies a setting is available in the GUI when its not.

dawehner’s picture

Category: bug » feature
Anybody’s picture

+1

zmove’s picture

+1 for this.

codesmith’s picture

+1

schifazl’s picture

+1

alex.87’s picture

+1

AntonLargiader’s picture

Actually the class specified in the "Advanced" area does work, but it acts on a DIV rather than on the table, so the CSS needs to read:

.yourclass table {}

rather than

table.yourclass {}

This is view-independent so you can have a favorite table style and select it for any view(s) you want. I was happy to find that I did not have to make a style for each view table or create a style for all view tables, which the other documentation led me to believe.

Nikolay Shapovalov’s picture

Issue summary: View changes

+1

schifazl’s picture

I think that this could be closed, since the solution in #14 works perfectly!

moniuch’s picture

I would vote that we close all requests and resort to workarounds, just because there's no will to address users' feedback.

schifazl’s picture

I thinked for a while about this issue. Adding a class to the table while it was already added to the entire view seems redundant to me, so I don't think that #14 is a workaround, but everyone has his own opinion ;)

zmove’s picture

It can be great to have the control over table class even if you can have a custom class in a parent div because more and more framework like bootstrap require to precisely give classes to your elements.

cybercampbell’s picture

Easiest way is to put the following in your template.php:

function THEME_preprocess_views_view_table(&$vars) {
  $vars['classes_array'][] = 'table';
}

and if you want striped tables:

function THEME_preprocess_views_view_table(&$vars) {
  $vars['classes_array'][] = 'table table-striped';
}

Hope that helps.

zmove’s picture

And if you want to have some table stripped and some tables not :)

Definitely it should be configurable in views.

mooru’s picture

The code in #20 is not working even after clearing cache

mark@redhorseinteractive.com’s picture

Maybe just add a line of jquery to a custom js file?

$( "table" ).addClass( "table table-striped" );

minorOffense’s picture

Status: Active » Needs review
FileSize
2.6 KB

I've created a patch which adds the option in the UI and the necessary changes to the preprocess function.

minorOffense’s picture

FileSize
2.64 KB

Last patch introduced a PHP warning. This removes the warning.

alex.skrypnyk’s picture

Status: Needs review » Reviewed & tested by the community

#25 works great

jedsaet’s picture

+1 RTBC to #25

nmillin’s picture

#25 works great

big_smile’s picture

#25 works for me too.

Cameron Tod’s picture

#25 works great here too. +1 :)

milos.kroulik’s picture

#25 works great and would be great addition to Views.

Anybody’s picture

+1 I agree. Any maintainer feedback? Can you include this into the next dev release and stable release afterwards?

mxwright’s picture

Priority: Normal » Major
colan’s picture

We've recently switched our testing from the old qa.drupal.org to DrupalCI. Because of a bug in the new system, #2623840: Views (D7) patches not being tested, older patches must be re-uploaded. On re-uploading the patch, please set the status to "Needs Review" so that the test bot will add it to its queue.

If all tests pass, change the Status back to "Reviewed & tested by the community". We'll most likely commit the patch immediately without having to go through another round of peer review.

We apologize for the trouble, and appreciate your patience.

Anybody’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
2.64 KB

Re-uploaded #25 as of #34

Anybody’s picture

Status: Needs review » Reviewed & tested by the community
knalstaaf’s picture

Support for field tokens would top it off though…

Sneakyvv’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
2.64 KB

#35 works great, thanks!

However... I renamed the patch according to the patch naming convention as it is a real hassle to update contrib modules if the patch names don't start with the module name.

Sneakyvv’s picture

Status: Needs review » Reviewed & tested by the community

back to RTBC as new patch passes tests and only changes a typo (and patch name).

darrenwh’s picture

Status: Reviewed & tested by the community » Needs work
  1. +++ b/theme/theme.inc
    @@ -466,10 +466,25 @@ function template_preprocess_views_view_table(&$vars) {
    +    if (!empty($class)) {
    

    Same here why not just use isset($class)

  2. +++ b/theme/theme.inc
    @@ -466,10 +466,25 @@ function template_preprocess_views_view_table(&$vars) {
    +      // Trim empty class entries
    

    This comment is missing a period (.) at the end

  3. +++ b/theme/theme.inc
    @@ -466,10 +466,25 @@ function template_preprocess_views_view_table(&$vars) {
    +      foreach ($class as $key => $c) {
    

    Could the value be more descriptive what is c$?

minorOffense’s picture

Status: Needs work » Needs review
FileSize
2.7 KB

I made some of the changes. Fixed the comment. I added an isset but left most as !empty since I actually want to check if something isn't blank or 0. The variable will most always actually be set but I want to prevent blank values from getting into the classes array.

interdruper’s picture

Status: Needs review » Reviewed & tested by the community

#41 works fine.

Note that #20 approach also works fine, if you want to easily add a class to every table from views in your theme.

dreftymac’s picture

For those who are not averse to a javascript solution, here is some sample jQuery code.

<script data-dmid="d7views_cssinject_tableclasses">
jQuery(document).ready(function() {
  jQuery("table.views-table").addClass("table");
  jQuery("table.views-table").addClass("table-condensed");
  jQuery("table.views-table").addClass("table-striped");
  jQuery("table.views-table").addClass("table-hover");
  jQuery("table.views-table").addClass("table-bordered");
});
</script>
DamienMcKenna’s picture

What's the rationale to use views_clean_css_identifier() vs drupal_clean_css_identifier()?

minorOffense’s picture

It mirrors how the list classes are sanitized. Well at least when I originally wrote the patch years ago. If that's changed then just use whatever the current function should be.

nironan’s picture

#41 did the trick for me, thanks!

NWOM’s picture

#41 worked for me as well. Thanks so much!

Anybody’s picture

I can confirm RTBC.
Can we have this in the next views 7.x release?

Furthermore how do we go on porting this to Drupal 8? New issue for core? Drupal 8 views table also only have rows classes.

Prometheus2704’s picture

Status: Reviewed & tested by the community » Active

Can this be incorporated into the next dev release or an updated patch?

The latest patch in this thread doesn't work on the current stable or dev versions

NWOM’s picture

Priority: Major » Normal
Status: Active » Needs work

According to #49, it needs a re-roll most likely against the newest dev.

nmillin’s picture

Status: Needs work » Needs review
FileSize
2.71 KB

Re-roll against dev after confirming patch didn't apply cleanly.

Ken Hawkins’s picture

This is really helpful.

Applying cleanly and works as expected against latest dev for me.

Ken Hawkins’s picture

Status: Needs review » Reviewed & tested by the community

Being bold — this one's clearly been around for a good bit of testing and peer review over the last several years.

RunOfTheMill’s picture

I ended up here when trying to figure out how to add bootstrap classes to the table element. Trying to keep the site light and not use jQuery, so I was looking for a plain JS solution to #23 and #43. The simplest .classList function only seems to work on getElementByID, but this table doesn't have an ID.

After some digging, I came across this post which had a work-around that allows javascript's .classList function to be applied to multiple elements. I adapted it to this situation below, providing a plain vanilla javascript solution to adding bootstrap classes to tables generated by Views.

var tables = document.querySelectorAll('table');
for (var i = 0; i < tables.length; i++) {
    tables[i].classList.add('table','table-striped');
}
DamienMcKenna’s picture

jedsaet’s picture

Status: Needs review » Reviewed & tested by the community

Thanks! #55 patches against current dev and does the trick.

DamienMcKenna’s picture

Anybody’s picture

Whao this is great news :)
Should we create a separate issue for Drupal 8 afterwards or handle the follow-up here?

DamienMcKenna’s picture

Yes, please create a separate issue for D8, if there isn't one already, and list it as a "related issue". Thanks.

  • DamienMcKenna committed f3ce424 on 7.x-3.x
    Issue #1689472 by minorOffense, DamienMcKenna, Anybody, nmillin,...
DamienMcKenna’s picture

Status: Reviewed & tested by the community » Fixed

Committed. Thanks everyone.

Anybody’s picture

Drupal 8 Follow-up: #3045871: Add "Table class" option to views table formatter UI

(I couldn't find a Drupal 8 issue for that yet)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.