Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#15 | book-1925196-15.patch | 6.03 KB | robmc |
#9 | book-1925196-6.patch | 6.03 KB | joergM |
#6 | book-1925196-5.patch | 6.62 KB | joergM |
#4 | book-1925196-4.patch | 7.48 KB | tim.plunkett |
#2 | book-1925196-2.patch | 7.38 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettContains #1921996: Convert system_config_form() to implement FormInterface as a base class. and #1925140: drupal_form_submit() does not accept FormInterface objects for now.
Comment #2
tim.plunkettThose other issues were committed.
Comment #4
tim.plunkettRerolled for #1928082: Make usage of book.settings:allowed_types consistent.
Comment #5
tim.plunkettThis needs a reroll, use #1925738: Convert language's system_config_form() to SystemConfigFormBase as a guide
Comment #6
joergM CreditAttribution: joergM commentedChanged implementation of conversion book's system_config_form() to SystemConfigFormBase according to the implementation of #1925738: Convert language's system_config_form() to SystemConfigFormBase.
Use _form: 'Drupal\book\BookSettingsForm' instead of _controller: 'book.form.settings:getForm' in book.routing.yaml
Comment #7
joergM CreditAttribution: joergM commentedNeeds review to trigger testbot
Comment #8
amateescu CreditAttribution: amateescu commentedAll of these are not necessary anymore because the base class takes care of that. Also, don't forget to remove
use Drupal\Core\Config\ConfigFactory;
as well.Comment #9
joergM CreditAttribution: joergM commentedRemoval of superfluous ConfigFactory stuff according to amateescu review comment.
Comment #10
amateescu CreditAttribution: amateescu commentedLooks great now! Thanks for the quick reroll :) Let's wait for the testbot before marking RTBC.
Comment #11
Crell CreditAttribution: Crell commentedComment #12
Crell CreditAttribution: Crell commentedAs of last night, this should instead specify 'route' => 'book_settings' and then no page callback at all.
Comment #13
amateescu CreditAttribution: amateescu commentedComment #14
robmc CreditAttribution: robmc commentedComment #15
robmc CreditAttribution: robmc commentedre-rolled with route_name change.
Comment #16
robmc CreditAttribution: robmc commentedComment #17
robmc CreditAttribution: robmc commentedComment #18
Crell CreditAttribution: Crell commentedAnd there was much rejoicing!
Comment #19
webchickYAY! Great to see these patches starting to flow!
Committed and pushed to 8.x. Thanks!