As of #1875086: Improve DX of drupal_container()->get() the drupal_container() function has been replaced. This is a meta issue to track issues for updating all of the individual use cases.

CommentFileSizeAuthor
#3 1938334.patch247.22 KBamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

Crell’s picture

amateescu’s picture

Component: ajax system » other
Status: Active » Needs review
Issue tags: +SprintWeekend2013
FileSize
247.22 KB

Do we really need a meta issue for a simple regexp?

dawehner’s picture

Status: Needs review » Needs work

-1 to replace everything in one go.

One reason is that modules want to provide their own services see the issue in comment #2.
This seems to be a good splitable novice issue, sorry :(

amateescu’s picture

Status: Needs work » Needs review

One reason is that modules want to provide their own services see the issue in comment #2.

And they can do so in followup issues. While moving procedural forms to classes and menu items to the new router are indeed good splitable issues, this one will be a huge waste of testbot and committers time.

Berdir’s picture

Hm. What about first converting the ones that will get a specific method in #1937600: Determine what services to register in the new Drupal class and then do the remaining ones here?

amateescu’s picture

Status: Needs review » Postponed

That sounds better.

xjm’s picture

@amateescu, past experience shows that it's the large, monolithic patches that are a waste of reviewers' and committers' time. Simple string replaces that touch hundreds of files break everything and tend to stall for months or years. Incremental issues with a reasonable scope are less disruptive to review, maintain, and commit. We've seen this time and again.

salvis’s picture

I'm proposing to #1957804: Add a nothrow option to Drupal::service(), which will make some of the required updates easier.

ddrozdik’s picture

Some work in this direction has already been made here #2001206: Replace drupal_container() with Drupal::service()

webchick’s picture

Status: Postponed » Closed (duplicate)

Seems like this is a dupe.