Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
In order to bring the Edit module functionality to a level that allows for us substantial interactive testing, several measures were taken in the code to paper over Toolbar issues currently under development. Most importantly, the definition of the hook_toolbar hook.
#1847198: Update the structure returned by hook_toolbar()
When the definition of hook_toolbar is established, we will be able to refactor several aspects of Edit to make the module more extensible and flexible for contrib additions.
Proposed resolution
Remove the module dependency on the toolbar module.
Remove JavaScript code in several places that address gaps in the Toolbar such as the lack of an API to hide all trays and deactivate tabs other than the one that was clicked. Blocked on #1860434: Refactor the Toolbar JavaScript to use Backbone; fix several poorly functioning behaviors.
Remaining tasks
TBD.
User interface changes
TBD. Probably none.
API changes
Probably none.
Comments
Comment #1
Wim LeersThe toolbar dependency was removed in #1824500-89: In-place editing for Fields (see the reasoning in #1824500-78: In-place editing for Fields, second paragraph).
That still leaves the hard part to be done though :)
Comment #2
Wim LeersI think this was completed implicitly over at #1874664: Introduce toolbar level "Edit" mode that shows all contextual links:
There is no more need to have a view/edit mode toggle in a tray; hence this no longer applies:
Thus, I believe this issue was addressed in its entirety.