propertyCondition('uid', 'value', $last_orphan_checked, '>')

What is 'value' being called on? There is no uid_value field. This should be removed.

CommentFileSizeAuthor
#1 ldap_user_cron_property_bug-1853310-1.patch808 bytessuperspring
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

superspring’s picture

superspring CreditAttribution: superspring commented
Status: Active » Needs review
FileSize
ldap_user_cron_property_bug-1853310-1.patch808 bytes

Patch as described above.

johnbarclay’s picture

johnbarclay CreditAttribution: johnbarclay commented
Title: ldap_user_cron EntityFieldQuery bug. » LDAP User: cron for removing orphaned ldap users bugs

thanks. I committed this. The counter wasn't being set either, so it would have kept starting at the lowest uids first each time. The commit is: http://drupalcode.org/project/ldap.git/commitdiff/85dfcc898ca159e239fb72...

I'm leaving this open as this code has obviously not been tested.

johnbarclay’s picture

johnbarclay CreditAttribution: johnbarclay commented

this patch was closer, but still broken. The fix is applied at: http://drupalcode.org/project/ldap.git/commitdiff/2d319b15f70bced8ea5949...

So the simpletests work again, but it still needs some real world testing.

johnbarclay’s picture

johnbarclay CreditAttribution: johnbarclay commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.