Problem/Motivation
node and comment links use the "Translations" text.
But, we want parity with what admin/content and the like listings are doing now. Those dropbuttons all use "action" keywords: 'view', 'edit', 'translate'.
On the other hand, on nodes we also have "revisions" tab, which is a noun.
Proposed resolution
Unify dropbutton use of translate/translations wording in links
Remaining tasks
find all the locations that use translate/translations
decide if it should be translate or translations
User interface changes
No new UI patterns, just being consistant with wording
API changes
No API changes.
Original report by @webchick and @plach
Follow up for #30-#34 #1896268-30: Add Views integration for translation_entity
+ public function render_link(EntityInterface $entity, \stdClass $values) {
+ if (translation_entity_translate_access($entity)) {
+ $text = !empty($this->options['text']) ? $this->options['text'] : t('view');
This is a link to node/1/translations and the like, not node/1/view. So it should not be labeled 'view.' :)
[...] (renamed to 'translate')
Comment | File | Size | Author |
---|---|---|---|
#22 | unify-translations-wording-1899486-20.patch | 5.4 KB | YesCT |
#22 | interdiff-18-20.txt | 662 bytes | YesCT |
#20 | translations-comment.png | 110.01 KB | YesCT |
#18 | translate.patch | 4.75 KB | Gábor Hojtsy |
#8 | unify-translations-wording-1899486-8.patch | 2.27 KB | pixelite |
Comments
Comment #1
shnark CreditAttribution: shnark commenteddownload and install drupal 8.
create content
under extend, enable content translation
add a couple languages, in admin/config/regional/language
enable translation in admin/config/regional/content-language by checking the checkbox for content and then article. and save.
go to content, click dropbotton:
I made a change to my content, and save revision:
I made a comment
I went to menu, configuration, content language settings, and enabled comment translations.
reload the content that you created
Click translation link, beneath the comment
Comment #2
shnark CreditAttribution: shnark commentedThe first dropbotton says translate, but it takes you to a page that says "translations of Content", and doesn't actually translate.
The other places that I found that said translations, are all used correctly, taking you to lists of translations.
Comment #3
shnark CreditAttribution: shnark commentedI think the the dropbotton at Menu >> Content, or admin/content, should be changed to translations, instead of translate.
Comment #4
rachel_norfolkHmm - after following the instructions up to the first screenshot with today's 8.x branch, I've just received a PHP error, as attached, so can't follow through...
environment: Mac, Acquia Dev Desktop 7.19.18, Safari
Comment #5
YesCT CreditAttribution: YesCT commented@rachellawson Thanks for taking a look at this.
I went through the steps too just now with a fresh git pull on the 8.x branch. And I'm not able to reproduce that error.
Would you try some of the things in this post about reproducing:
http://www.comm-press.de/en/blog/when-having-trouble-reproducing-issue-o...
Comment #6
edrupal CreditAttribution: edrupal commentedI was able to recreate the issue taking the following steps:
Comment #7
YesCT CreditAttribution: YesCT commentednote, the property error found in #4 is probably this unrelated issue: #1938384: "Undefined property" error only after adding translations to existing content.
Comment #8
pixeliteUpdated the wording to 'Translations' in the operations column of the node, comments, taxonomy term, and user admin UI.
For example, in the node admin UI:
Attaching a patch with this change.
Comment #9
sahain CreditAttribution: sahain commentedComment #10
sahain CreditAttribution: sahain commentedComment #11
sahain CreditAttribution: sahain commentedApplied latest patch and reviewed visually. Changes look good.
Comment #12
Gábor HojtsyHm, this is an interesting one :) I personally believe the tab and dropdown would maybe better be "Translate" as in an active verb. I do see how the tab only leads to a list of translations which *then* lets you translate from another action there. So maybe this is not 100% correct, but I see it as parallel to the experince of "Edit", etc. While "Revisions" does list revisions as well (alike Translations listing translations), it is not the 80% use case to *act* on revisions on that tab, while it is *absolutely* the 80% use case to act on translations on this page.
Comment #13
Gábor HojtsyAlso the config translation module proposed for core at #1952394: Add configuration translation user interface module in core (also http://drupal.org/project/config_translation) uses "Translate" consistently everywhere. Not saying that is any proof, because it may be the most underused Drupal 8 module :D
Comment #14
Gábor HojtsyComment #15
Schnitzel CreditAttribution: Schnitzel commentedDiscussed with YesCT and Gabor, we all agreed that we should use "Translate", as this is the first action a User want's to do when there is no translation yet. And even it shows you a Table of all translations, so "Translations" would be super correct, we think the Verb ist still better.
Comment #16
chrishks CreditAttribution: chrishks commentedComment #17
Gábor HojtsyAs per #5, the Translations tab is still there, it should now be Translate. Issue is not fixed.
Comment #18
Gábor HojtsyHere is a quick patch to change as discussed above.
Comment #19
YesCT CreditAttribution: YesCT commentedthis looks good. did not try it manually yet. also did not grep for any remaining 'Translations' ...
Comment #20
YesCT CreditAttribution: YesCT commentedI tried this manually and noticed the comment link was still translations.
then I did a grep.
here is the grep (note to self, you could have grepped for inside of t()).
this changes the link for comment. the other two are items in an array which are fine.
Comment #21
YesCT CreditAttribution: YesCT commentedI noticed that the body of the comment seems out of order, occurring before the subject and author name.
A search needs to be done to see if an issue exists for that, and if not, an issue opened.
this has nothing to do with this issue and is not blocking this.
Comment #22
YesCT CreditAttribution: YesCT commentedsorry, here are is the patch.
Comment #23
Gábor HojtsyLooks great!
Comment #24
Gábor HojtsyComment #25
Gábor HojtsyComment #26
YesCT CreditAttribution: YesCT commented#22: unify-translations-wording-1899486-20.patch queued for re-testing.
Comment #28
YesCT CreditAttribution: YesCT commented#22: unify-translations-wording-1899486-20.patch queued for re-testing.
Comment #29
Gábor HojtsyPasses well.
Comment #30
Gábor HojtsyComment #31
jhodgdonDid you just want me to review this? I don't see any problems, looks fine.
But I don't normally commit patches for UI text (I'm no usability expert), so I'll un-assign this one. :)
Comment #32
Gábor HojtsyBack to @jhodgdon after @catch verified she would be fine to commit UI element text changes like this.
Comment #33
jhodgdonThanks all! Committed to 8.x.
Comment #34
Gábor HojtsyWoot, thanks!
Comment #35
Gábor Hojtsy