A white background is added to all the DIV elements once you click 'quick edit', i suppose through JS.
This doesn´t work for white texts over dark backgrounds, as you can´t read them.
You can´t override it as it´s added to each element, unless you use javascript, but I suppose it isn´t really necessary, as it is 'true' wysiwyg.

Comments

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Category: task » bug

Good to know, will look at it next week.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

Relevant code: css/edit.css, #edit_overlay selector.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Title: White background through JS: » White background through JS
Status: Active » Fixed

JS is not setting the background directly anymore. It gets wierd for dark backgrounds, it should be readable at least.

There are no visual changes for white ones.

http://drupalcode.org/project/edit.git/commitdiff/1b5b76c693278e972b9dc3...

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Issue tags: +Edit D7 Backport

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Closed (fixed) » Fixed

This commit modified the wrong piece of CSS. Furthermore, if the background color handling is disabled, then Drupal.edit.views.PropertyEditorDecorationView._getBgColor() can indeed be removed.

The changes to make here clashed with f51d1ed9ea619245ece4527ac63c982656906eef, which doesn't work at all, so I'm reverting that at the same time.

See http://drupalcode.org/project/edit.git/commit/1251ab6.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Issue tags: +Spark

.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nuez’s picture

nuez
Primary language Dutch
Location Madrid, Spain
CreditAttribution: nuez commented
Status: Closed (fixed) » Active

This issue has reappeared

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

#9: version?

dmsmidt’s picture

dmsmidt
he/him
Primary language Dutch
Location Amsterdam 🇳🇱🇪🇺
CreditAttribution: dmsmidt commented

I can't reproduce this on the latest version. Background doesn't become white on dark themes.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Active » Fixed

Hm. Tentatively moving back to fixed. Nuez, if you can still reproduce this on the latest version, can you post back with more details (browser, making doubly sure all browser caches are cleared, etc.)?

nuez’s picture

nuez
Primary language Dutch
Location Madrid, Spain
CreditAttribution: nuez commented

Confirmed, it works as expected. Thanks

As I understand it, Edit takes the background color of the parent element, and adds it as inline color to contrast against the overlay.

My problem was that I had a dark background image, not a background color. You need to add a dark background color as well to the CSS to make it work.

Thanks again,

Automatically closed -- issue fixed for 2 weeks with no activity.