Code looks like 

  // This will perform a node_access check, so we don't have to.
  return ctools_context_create('user_edit_form', $account);
  return NULL;

And the last return is unnecessary.

CommentFileSizeAuthor
double-returns-user_edit.patch458 bytesanon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Needs review » Fixed

Committed and pushed.

Jorrit’s picture

Jorrit CreditAttribution: Jorrit commented

Be aware that your commit (http://drupalcode.org/project/ctools.git/commit/12d6b1d) contained more than just the above patch.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

Huh. The other commit is intended, at least, but I thought they were separate. I must've messed up a commit command.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Priority: Minor » Critical
Status: Closed (fixed) » Active

This commit introduces a huge performance regression with hook_process() fired for most of renderables. So better to revert it and split the hook into limited set of elements that allowed to accept class injections

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

This changes was from #1775660: Move the code for adding/removing classes from Panels to CTools that does get no testing and no profiling

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Priority: Critical » Minor
Status: Active » Closed (fixed)

Shout be fixed in #1775660: Move the code for adding/removing classes from Panels to CTools